Draft
Conversation
asylumexp
commented
Mar 7, 2026
asylumexp
commented
Mar 7, 2026
Member
michelroegl-brunner
left a comment
michelroegl-brunner
left a comment
There was a problem hiding this comment.
Looks like a solid solution to implement the ARM scripts in the repo. We then dont even need any special calls for the scripts when a user wants to run the arm version. I really like that. As i see for the install script, you just basicly put the arm needed stuff in front of the AMD64 install script?
michelroegl-brunner
previously approved these changes
Mar 10, 2026
CrazyWolf13
requested changes
Mar 10, 2026
Member
CrazyWolf13
left a comment
CrazyWolf13
left a comment
There was a problem hiding this comment.
Was this tested in VED repo?
Should we consider adding a short whitail popup, that arm support is in beta or active development and there may be stuff that is not yet fully tested/working?
misc/build.func
Outdated
Comment on lines
+5027
to
+5034
| 11 | 11.*) echo "bullseye" ;; 12 | 12.*) echo "bookworm" ;; | ||
| 13 | 13.*) echo "trixie" ;; *) echo "trixie" ;; | ||
| esac ;; | ||
| alpine) echo "3.22" ;; | ||
| ubuntu) | ||
| case "$2" in | ||
| 20.04* | focal) echo "focal" ;; 24.04* | noble) echo "noble" ;; | ||
| 24.10* | oracular) echo "oracular" ;; *) echo "jammy" ;; |
Member
There was a problem hiding this comment.
there keep coming new places where we have to specify version, would it make sense to use shared variables to make updating easier?
Co-authored-by: Tobias <96661824+CrazyWolf13@users.noreply.github.com>
Co-authored-by: Tobias <96661824+CrazyWolf13@users.noreply.github.com>
Co-authored-by: Tobias <96661824+CrazyWolf13@users.noreply.github.com>
Co-authored-by: Tobias <96661824+CrazyWolf13@users.noreply.github.com>
Legacy support removed since no cts use them anymore.
Add clearer architecture error messages and gate arm64 usage, plus implement architecture-aware behavior across the toolkit. Changes include: update exit-code messages to reference amd64/arm64, refuse arm64 unless explicitly enabled, show architecture in summaries, and use arch-specific package lists when installing in containers. Make downloads for FFmpeg and yq choose the correct amd64/arm64 binaries, tighten template download error handling and formatting, and clean up minor whitespace/comment issues. These changes aim to make arm64 handling explicit and downloads/installations more robust for non-amd64 systems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✍️ Description
Adds support for creating arm64 Ubuntu, Debian, and alpine containers via scripts.
✅ Prerequisites (X in brackets)
🛠️ Type of Change (X in brackets)
README,AppName.md,CONTRIBUTING.md, or other docs.