Skip to content

feat: update UHF Server script to use setup_ffmpeg#13564

Merged
MickLesk merged 1 commit intocommunity-scripts:mainfrom
zackwithak13:feature/update-uhf-script-with-setup-ffmpeg
Apr 8, 2026
Merged

feat: update UHF Server script to use setup_ffmpeg#13564
MickLesk merged 1 commit intocommunity-scripts:mainfrom
zackwithak13:feature/update-uhf-script-with-setup-ffmpeg

Conversation

@zackwithak13
Copy link
Copy Markdown
Contributor

@zackwithak13 zackwithak13 commented Apr 6, 2026

✍️ Description

This PR updates the UHF script to install ffmpeg using the shared setup_ffmpeg function, instead of using the debian repo.

🔗 Related Issue

Fixes #

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

@zackwithak13 zackwithak13 requested a review from a team as a code owner April 6, 2026 23:30
@github-actions github-actions bot added refactor update script A change that updates a script labels Apr 6, 2026
@MickLesk
Copy link
Copy Markdown
Member

MickLesk commented Apr 7, 2026

setup_ffmpeg build from source and take many time. Why for UHF? and why no profile? Really the FULL FFMPEG Codecs?

@zackwithak13
Copy link
Copy Markdown
Contributor Author

@MickLesk I wanted to use the latest stable ffmpeg version, not the one available on stable Debian and figured using the supplied util made most sense. full is the only one to include x265, which is a fairly common codec to use

@MickLesk
Copy link
Copy Markdown
Member

MickLesk commented Apr 7, 2026

@CrazyWolf13
Copy link
Copy Markdown
Member

@MickLesk I think he is right on that.

Isn't x265 more widely used for it to be only in full?

https://github.com/community-scripts/ProxmoxVE/blob/main/misc%2Ftools.func#L3929-L3930

@MickLesk MickLesk merged commit 74c430d into community-scripts:main Apr 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor update script A change that updates a script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants