Skip to content

fix(flaresolverr): use rm -f for google-chrome.list (Debian 13 Trixie)#13580

Closed
WickedSick31 wants to merge 1 commit intocommunity-scripts:mainfrom
WickedSick31:fix/flaresolverr-chrome-list-trixie
Closed

fix(flaresolverr): use rm -f for google-chrome.list (Debian 13 Trixie)#13580
WickedSick31 wants to merge 1 commit intocommunity-scripts:mainfrom
WickedSick31:fix/flaresolverr-chrome-list-trixie

Conversation

@WickedSick31
Copy link
Copy Markdown

@WickedSick31 WickedSick31 commented Apr 7, 2026

✍️ Description

Fix FlareSolverr installer aborting at line 32 of install/flaresolverr-install.sh with:

[ERROR] in line 32: exit code 1 (General error / Operation not permitted): while executing command rm /etc/apt/sources.list.d/google-chrome.list

Root cause: On Debian 13 "Trixie", google-chrome-stable's postinst script detects the pre-existing deb822 .sources file written earlier by setup_deb822_repo and skips writing the legacy /etc/apt/sources.list.d/google-chrome.list. The subsequent unconditional rm then fails because the file never existed, and catch_errors aborts the install.

Fix: Switch rmrm -f so the cleanup is a no-op when the file is absent, while still removing it on hosts/edge cases where postinst did create it. Also updated the inline comment to explain the Trixie behavior.

🔗 Related Issue

Fixes #13585

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Verified fresh FlareSolverr LXC create on a Debian 13 Trixie template completes past the Chrome install step; apt update inside the container produces no duplicate-repo warnings (only the .sources file remains).
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues. rm -f is a drop-in replacement of the existing rm with identical scope.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

On Debian 13 "Trixie", google-chrome-stable's postinst detects the
pre-existing deb822 .sources file created by setup_deb822_repo and
skips writing the legacy /etc/apt/sources.list.d/google-chrome.list.
The subsequent unconditional `rm` then fails with exit 1, tripping
catch_errors and aborting the install at line 32.

Switch to `rm -f` so the cleanup is a no-op when the file was never
written, while still removing it on hosts where postinst did create it.
@WickedSick31 WickedSick31 requested a review from a team as a code owner April 7, 2026 20:17
@github-actions github-actions bot added the update script A change that updates a script label Apr 7, 2026
Copy link
Copy Markdown
Member

@michelroegl-brunner michelroegl-brunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a PR Temlate for a Reason, restore that and fill it out poperly before we can continue here...

@michelroegl-brunner
Copy link
Copy Markdown
Member

#13584

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix update script A change that updates a script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flaresolverr: install fails at line 32 removing non-existent google-chrome.list on Debian 13 Trixie

3 participants