Skip to content

profilarr: Fix ARCH assignment in profilarr.sh to support Profilarr build usage - #14709

Merged
MickLesk merged 1 commit into
community-scripts:mainfrom
mpeleshenko:patch-1
May 26, 2026
Merged

profilarr: Fix ARCH assignment in profilarr.sh to support Profilarr build usage#14709
MickLesk merged 1 commit into
community-scripts:mainfrom
mpeleshenko:patch-1

Conversation

@mpeleshenko

@mpeleshenko mpeleshenko commented May 25, 2026

Copy link
Copy Markdown
Contributor

✍️ Description

Fix profilarr update error coming from deno compile as ARCH is not set when updating an existing installation, but is used when setting DENO_TARGET.

🔗 Related Issue

None

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to script metadata (PocketBase/website data).
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

@mpeleshenko
mpeleshenko requested a review from a team as a code owner May 25, 2026 18:00
@github-actions github-actions Bot added bugfix update script A change that updates a script labels May 25, 2026
@MickLesk

Copy link
Copy Markdown
Member

Whats the issue? I dont See any Change with the Line Switch. 🤔

@mpeleshenko

Copy link
Copy Markdown
Contributor Author

When running update in the container after I had previously installed 2.0.4 from scratch, I got an error about an invalid parameter -u for the deno compile command. I traced it down to DENO_TARGET="${ARCH}-unknown-linux-gnu" requiring ARCH to be set, but when there is no deno update, it is not set, so I moved it outside the if to cater to both deno and profilarr updates.

@michelroegl-brunner michelroegl-brunner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, $ARCH is required in Line 77

@MickLesk MickLesk changed the title fix(profilarr): Fix ARCH assignment in profilarr.sh to support Profilarr build usage profilarr: Fix ARCH assignment in profilarr.sh to support Profilarr build usage May 26, 2026
@MickLesk
MickLesk merged commit a36b2c9 into community-scripts:main May 26, 2026
4 checks passed
@SystemIdleProcess

Copy link
Copy Markdown
Contributor

Since update does clean, need to mkdir /opt/profilarr/app before it can copy the build there.

@MickLesk

Copy link
Copy Markdown
Member

Make an PR ^^

@SystemIdleProcess SystemIdleProcess mentioned this pull request May 26, 2026
10 tasks
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix update script A change that updates a script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants