Skip to content

RomM: remove nginx default.conf during installation - #14766

Merged
tremor021 merged 1 commit into
mainfrom
fix/romm-nginx-default-conf
May 28, 2026
Merged

RomM: remove nginx default.conf during installation#14766
tremor021 merged 1 commit into
mainfrom
fix/romm-nginx-default-conf

Conversation

@MickLesk

Copy link
Copy Markdown
Member

✍️ Description

/etc/nginx/conf.d/default.conf was not removed, causing nginx to serve the default welcome page instead of RomM because conf.d/ is loaded before sites-enabled/.

🔗 Related Issue

Fixes #14736

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to script metadata (PocketBase/website data).
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

/etc/nginx/conf.d/default.conf was not removed, causing nginx to serve
the default welcome page instead of RomM because conf.d/ is loaded
before sites-enabled/.

Fixes #14736
@MickLesk
MickLesk requested a review from a team as a code owner May 28, 2026 05:32
@github-actions github-actions Bot added bugfix update script A change that updates a script labels May 28, 2026
@tremor021
tremor021 merged commit 7703edf into main May 28, 2026
2 checks passed
Learath pushed a commit to Learath/ProxmoxVE that referenced this pull request May 31, 2026
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 1, 2026
@github-actions
github-actions Bot deleted the fix/romm-nginx-default-conf branch June 3, 2026 09:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix update script A change that updates a script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RomM: nginx default.conf not removed during installation

3 participants