Skip to content

[FileFlows] Fix service handling by using systemctl --all with quoted glob - #14838

Merged
michelroegl-brunner merged 1 commit into
community-scripts:mainfrom
adrianmusante:fix/fileflows-update
Jun 1, 2026
Merged

[FileFlows] Fix service handling by using systemctl --all with quoted glob#14838
michelroegl-brunner merged 1 commit into
community-scripts:mainfrom
adrianmusante:fix/fileflows-update

Conversation

@adrianmusante

Copy link
Copy Markdown
Contributor

✍️ Description

This PR fixes an issue in the FileFlows update script where the service is not properly stopped or restarted during the update process. The root cause is the use of:

systemctl stop fileflows*
systemctl start fileflows*

Systemd does not expand shell-style globs as expected, which results in warnings and prevents all FileFlows-related units from being handled correctly.
The fix replaces these calls with proper systemd globbing using --all and a quoted pattern:

systemctl --all stop 'fileflows*'
systemctl --all start 'fileflows*'

This ensures that all FileFlows services are properly stopped and started during the update process.

🔗 Related Issue

Fixes #14836

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to script metadata (PocketBase/website data).
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

@adrianmusante
adrianmusante requested a review from a team as a code owner May 31, 2026 21:36
@github-actions github-actions Bot added bugfix update script A change that updates a script labels May 31, 2026
@michelroegl-brunner
michelroegl-brunner merged commit 5776f3f into community-scripts:main Jun 1, 2026
2 checks passed
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix update script A change that updates a script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FileFlows] Incorrect use of systemctl start/stop fileflows* for update

3 participants