Skip to content

Glance: preserve glance.yml across updates - #14845

Merged
CrazyWolf13 merged 1 commit into
mainfrom
fix/glance-update-backup-config
Jun 1, 2026
Merged

Glance: preserve glance.yml across updates#14845
CrazyWolf13 merged 1 commit into
mainfrom
fix/glance-update-backup-config

Conversation

@michelroegl-brunner

@michelroegl-brunner michelroegl-brunner commented Jun 1, 2026

Copy link
Copy Markdown
Member

✍️ Description

Glance updates used CLEAN_INSTALL=1, which removed /opt/glance/glance.yml while redeploying the prebuild binary only. The service then failed because systemd points at the missing config file.

This change backs up glance.yml to /tmp before the clean install and restores it afterward, matching patterns used by other scripts (e.g. Homer, rustypaste).

🔗 Related Issue

Fixes #14826

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected. (Requires a Glance LXC; see test plan below.)
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to script metadata (PocketBase/website data).
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

CLEAN_INSTALL wipes /opt/glance without restoring user config; back up and restore glance.yml around the prebuild deploy.

Co-authored-by: Cursor <cursoragent@cursor.com>
@michelroegl-brunner
michelroegl-brunner requested a review from a team as a code owner June 1, 2026 08:09
@github-actions github-actions Bot added bugfix update script A change that updates a script labels Jun 1, 2026
@MickLesk MickLesk changed the title fix(glance): preserve glance.yml across updates Glance: preserve glance.yml across updates Jun 1, 2026
@CrazyWolf13
CrazyWolf13 merged commit ded4bba into main Jun 1, 2026
4 checks passed
@github-actions
github-actions Bot deleted the fix/glance-update-backup-config branch June 3, 2026 09:16
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix update script A change that updates a script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Glance] update deletes glance.yml

3 participants