Skip to content

fix(firefly): set Data Importer APP_URL for subdirectory install - #14847

Merged
tremor021 merged 1 commit into
mainfrom
fix/firefly-dataimporter-subdirectory-urls
Jun 1, 2026
Merged

fix(firefly): set Data Importer APP_URL for subdirectory install#14847
tremor021 merged 1 commit into
mainfrom
fix/firefly-dataimporter-subdirectory-urls

Conversation

@michelroegl-brunner

@michelroegl-brunner michelroegl-brunner commented Jun 1, 2026

Copy link
Copy Markdown
Member

✍️ Description

When the Firefly III Data Importer is served under the Apache /dataimporter/ alias, Laravel's route('index') was generated against the default APP_URL (http://localhost), so Start Over redirected to / instead of /dataimporter/ and users hit a 404.

This PR sets APP_URL and ASSET_URL in the Data Importer .env during install and runs php artisan config:clear so URL generation matches the subdirectory deployment.

🔗 Related Issue

Fixes #14830

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to script metadata (PocketBase/website data).
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

Configure APP_URL and ASSET_URL during install so redirects (e.g. Start Over) resolve to /dataimporter/ instead of the server root.

Fixes #14830

Co-authored-by: Cursor <cursoragent@cursor.com>
@michelroegl-brunner
michelroegl-brunner requested a review from a team as a code owner June 1, 2026 08:16
@github-actions github-actions Bot added bugfix update script A change that updates a script labels Jun 1, 2026
@tremor021
tremor021 merged commit 4659966 into main Jun 1, 2026
3 checks passed
@github-actions
github-actions Bot deleted the fix/firefly-dataimporter-subdirectory-urls branch June 3, 2026 09:16
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix update script A change that updates a script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Firefly III] Data importer does not put trailing / on URL when using start over

3 participants