fix(firefly): set Data Importer APP_URL for subdirectory install - #14847
Merged
Conversation
Configure APP_URL and ASSET_URL during install so redirects (e.g. Start Over) resolve to /dataimporter/ instead of the server root. Fixes #14830 Co-authored-by: Cursor <cursoragent@cursor.com>
CrazyWolf13
approved these changes
Jun 1, 2026
tremor021
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✍️ Description
When the Firefly III Data Importer is served under the Apache
/dataimporter/alias, Laravel'sroute('index')was generated against the defaultAPP_URL(http://localhost), so Start Over redirected to/instead of/dataimporter/and users hit a 404.This PR sets
APP_URLandASSET_URLin the Data Importer.envduring install and runsphp artisan config:clearso URL generation matches the subdirectory deployment.🔗 Related Issue
Fixes #14830
✅ Prerequisites (X in brackets)
🛠️ Type of Change (X in brackets)
README,AppName.md,CONTRIBUTING.md, or other docs.