fix(fireshare): rebuild client on update to fix nginx 500 - #14848
Merged
Conversation
After update, the frontend was not rebuilt while nginx still served /opt/fireshare/app/client/build, causing 500 errors. Match install behavior with npm install and npm run build. Fixes #14812 Co-authored-by: Cursor <cursoragent@cursor.com>
CrazyWolf13
approved these changes
Jun 1, 2026
tremor021
approved these changes
Jun 1, 2026
|
Thank you so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✍️ Description
Fireshare LXC updates redeploy the app and refresh the Python backend but did not rebuild the React client. Nginx continues to serve
/opt/fireshare/app/client/build, which is missing or stale afterCLEAN_INSTALL=1 fetch_and_deploy_gh_release, resulting in 500 Internal Server Error afterupdate(reported in #14812).This adds
npm installandnpm run buildinupdate_script(), matching the install script and peer scripts such as flatnotes.🔗 Related Issue
Fixes #14812
✅ Prerequisites (X in brackets)
🛠️ Type of Change (X in brackets)
README,AppName.md,CONTRIBUTING.md, or other docs.