Skip to content

fix(fireshare): rebuild client on update to fix nginx 500 - #14848

Merged
tremor021 merged 1 commit into
mainfrom
fix/fireshare-update-client-build
Jun 1, 2026
Merged

fix(fireshare): rebuild client on update to fix nginx 500#14848
tremor021 merged 1 commit into
mainfrom
fix/fireshare-update-client-build

Conversation

@michelroegl-brunner

Copy link
Copy Markdown
Member

✍️ Description

Fireshare LXC updates redeploy the app and refresh the Python backend but did not rebuild the React client. Nginx continues to serve /opt/fireshare/app/client/build, which is missing or stale after CLEAN_INSTALL=1 fetch_and_deploy_gh_release, resulting in 500 Internal Server Error after update (reported in #14812).

This adds npm install and npm run build in update_script(), matching the install script and peer scripts such as flatnotes.

🔗 Related Issue

Fixes #14812

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to script metadata (PocketBase/website data).
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

After update, the frontend was not rebuilt while nginx still served /opt/fireshare/app/client/build, causing 500 errors. Match install behavior with npm install and npm run build.

Fixes #14812

Co-authored-by: Cursor <cursoragent@cursor.com>
@michelroegl-brunner
michelroegl-brunner requested a review from a team as a code owner June 1, 2026 08:19
@github-actions github-actions Bot added bugfix update script A change that updates a script labels Jun 1, 2026
@tremor021
tremor021 merged commit e013403 into main Jun 1, 2026
2 checks passed
@geolup2000

Copy link
Copy Markdown

Thank you so much!

@github-actions
github-actions Bot deleted the fix/fireshare-update-client-build branch June 3, 2026 09:16
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix update script A change that updates a script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fireshare] Updating breaks the container

4 participants