Fix Kan build failure (TS7016 nodemailer) - #14856
Merged
Merged
Conversation
Sourcing .env sets NODE_ENV=production, which caused pnpm to skip devDependencies including @types/nodemailer. Add --prod=false to pnpm install in kan-install.sh and ct/kan.sh so @kan/email compiles during the monorepo build. Co-authored-by: Cursor <cursoragent@cursor.com>
MickLesk
approved these changes
Jun 1, 2026
tremor021
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✍️ Description
Kan install/update fails at
pnpm build --filter=@kan/webbecause@kan/emailcannot compile: TypeScript reports TS7016 fornodemailer(missing declaration file).The upstream Kan repo already includes
@types/nodemailerin devDependencies. Our scripts source/opt/kan/.env(which setsNODE_ENV=production) beforepnpm install, so pnpm skips devDependencies.This PR adds
--prod=falsetopnpm installininstall/kan-install.shandct/kan.shso dev deps (including@types/nodemailer,typescript, and workspace tooling) are installed for the build. Runtime still usesNODE_ENV=productionvia systemdEnvironmentFile.🔗 Related Issue
Fixes #
✅ Prerequisites (X in brackets)
🛠️ Type of Change (X in brackets)
README,AppName.md,CONTRIBUTING.md, or other docs.