fix(add-iptag): merge live IPv4 addresses for running LXCs - #16691
Conversation
|
👋 Hi @phillf, This pull request was closed because it does not follow the PR template. Please fix the following and open a new PR (or reopen this one after updating the description):
Maintainers can add the Thank you for contributing! 🙏 |
|
👋 Hi @phillf, This pull request was closed because it does not follow the PR template. Please fix the following and open a new PR (or reopen this one after updating the description):
Maintainers can add the Thank you for contributing! 🙏 |
|
Could someone please review this. The PR template has been corrected. |
|
@phillf your PR does not sem to match our current PR template, hence it got cloed (which it still doesn't seem to do) Here you can find our PR template: https://github.com/community-scripts/ProxmoxVE/blob/main/.github/pull_request_template.md |
|
👋 Hi @phillf, This pull request was closed because it does not follow the PR template. Please fix the following and open a new PR (or reopen this one after updating the description):
Maintainers can add the Thank you for contributing! 🙏 |
|
👋 Hi @phillf, This pull request was closed because it does not follow the PR template. Please fix the following and open a new PR (or reopen this one after updating the description):
Maintainers can add the Thank you for contributing! 🙏 |
1 similar comment
|
👋 Hi @phillf, This pull request was closed because it does not follow the PR template. Please fix the following and open a new PR (or reopen this one after updating the description):
Maintainers can add the Thank you for contributing! 🙏 |
|
I believe the template requirements should be met now. |
|
Nope. Fill it out yourself and dont let perplexity do it. Its a stupid model. |
✍️ Description
Fixes inconsistent IPv4 tag discovery for running LXC containers with a statically configured
net0address.Previously, an earlier discovery method could find the primary
net0/eth0address before the direct guest probe ran. Because the direct probe was guarded by[[ -z "$ips" ]], it was skipped when that primary address existed. This omitted additional guest interfaces such as Docker bridge networks and Tailscale.This change runs the direct discovery step for running LXCs:
Its results are merged with earlier discovery methods. The existing normalization step removes duplicates, while the existing
STATUS_CACHE[lxc_${vmid}]key preventspct execfrom running against stopped containers.This was prepared with assistance from Perplexity. The precise underlying model name/version and reasoning level were not exposed in this session, so they cannot be truthfully identified.
🔗 Related Issue
Fixes #16765
✅ Prerequisites (X in brackets)
🤖 AI Assistance (X in brackets)
AGENTS.mdand.github/agents/pve-script-creator.agent.mdas guidance, and the output has been reviewed and corrected to match those guidelines.🛠️ Type of Change (X in brackets)
README,AppName.md,CONTRIBUTING.md, or other docs.