Skip to content

fix(add-iptag): merge live IPv4 addresses for running LXCs - #16691

Closed
phillf wants to merge 1 commit into
community-scripts:mainfrom
phillf:fix/add-iptag-merge-live-lxc-ips
Closed

fix(add-iptag): merge live IPv4 addresses for running LXCs#16691
phillf wants to merge 1 commit into
community-scripts:mainfrom
phillf:fix/add-iptag-merge-live-lxc-ips

Conversation

@phillf

@phillf phillf commented Aug 22, 2026

Copy link
Copy Markdown

✍️ Description

Fixes inconsistent IPv4 tag discovery for running LXC containers with a statically configured net0 address.

Previously, an earlier discovery method could find the primary net0 / eth0 address before the direct guest probe ran. Because the direct probe was guarded by [[ -z "$ips" ]], it was skipped when that primary address existed. This omitted additional guest interfaces such as Docker bridge networks and Tailscale.

This change runs the direct discovery step for running LXCs:

pct exec <vmid> -- ip -4 addr show

Its results are merged with earlier discovery methods. The existing normalization step removes duplicates, while the existing STATUS_CACHE[lxc_${vmid}] key prevents pct exec from running against stopped containers.

This was prepared with assistance from Perplexity. The precise underlying model name/version and reasoning level were not exposed in this session, so they cannot be truthfully identified.

🔗 Related Issue

Fixes #16765

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🤖 AI Assistance (X in brackets)

If you used an AI tool (GitHub Copilot, Claude, ChatGPT, etc.) to write or generate any scripts in this PR, you must confirm compliance below.
Select exactly one option.

  • No AI used – Scripts were written without AI assistance.
  • AI was used – I confirm the scripts were built using AGENTS.md and .github/agents/pve-script-creator.agent.md as guidance, and the output has been reviewed and corrected to match those guidelines.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to script metadata (PocketBase/website data).
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

@phillf
phillf requested a review from a team as a code owner August 22, 2026 20:44
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi @phillf,

This pull request was closed because it does not follow the PR template.

Please fix the following and open a new PR (or reopen this one after updating the description):

  • Missing required section: ## ✍️ Description
  • Missing required section: ## ✅ Prerequisites
  • Missing required section: ## 🛠️ Type of Change
  • The Description section is empty.
  • Prerequisite not checked: Self-review completed
  • Prerequisite not checked: Tested thoroughly
  • Prerequisite not checked: No security risks
  • At least one Type of Change checkbox must be checked.

Use the template sections, fill in the description, check all prerequisite boxes, and select at least one type of change.

Maintainers can add the keep-open label to exempt a PR from this check.

Thank you for contributing! 🙏

@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi @phillf,

This pull request was closed because it does not follow the PR template.

Please fix the following and open a new PR (or reopen this one after updating the description):

  • Missing required section: ## ✅ Prerequisites
  • Prerequisite not checked: Self-review completed
  • Prerequisite not checked: Tested thoroughly
  • Prerequisite not checked: No security risks
  • At least one Type of Change checkbox must be checked.

Use the template sections, fill in the description, check all prerequisite boxes, and select at least one type of change.

Maintainers can add the keep-open label to exempt a PR from this check.

Thank you for contributing! 🙏

@phillf

phillf commented Aug 22, 2026

Copy link
Copy Markdown
Author

Could someone please review this. The PR template has been corrected.

@CrazyWolf13
CrazyWolf13 requested a review from MickLesk August 23, 2026 19:29
@CrazyWolf13

Copy link
Copy Markdown
Member

@phillf your PR does not sem to match our current PR template, hence it got cloed (which it still doesn't seem to do)

Here you can find our PR template: https://github.com/community-scripts/ProxmoxVE/blob/main/.github/pull_request_template.md

@CrazyWolf13 CrazyWolf13 reopened this Aug 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi @phillf,

This pull request was closed because it does not follow the PR template.

Please fix the following and open a new PR (or reopen this one after updating the description):

  • Missing required section: ## ✅ Prerequisites
  • Prerequisite not checked: Self-review completed
  • Prerequisite not checked: Tested thoroughly
  • Prerequisite not checked: No security risks
  • At least one Type of Change checkbox must be checked.

Use the template sections, fill in the description, check all prerequisite boxes, and select at least one type of change.

Maintainers can add the keep-open label to exempt a PR from this check.

Thank you for contributing! 🙏

@github-actions github-actions Bot closed this Aug 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi @phillf,

This pull request was closed because it does not follow the PR template.

Please fix the following and open a new PR (or reopen this one after updating the description):

  • Prerequisite not checked: Self-review completed
  • Prerequisite not checked: Tested thoroughly
  • Prerequisite not checked: No security risks
  • At least one Type of Change checkbox must be checked.

Use the template sections, fill in the description, check all prerequisite boxes, and select at least one type of change.

Maintainers can add the keep-open label to exempt a PR from this check.

Thank you for contributing! 🙏

1 similar comment
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi @phillf,

This pull request was closed because it does not follow the PR template.

Please fix the following and open a new PR (or reopen this one after updating the description):

  • Prerequisite not checked: Self-review completed
  • Prerequisite not checked: Tested thoroughly
  • Prerequisite not checked: No security risks
  • At least one Type of Change checkbox must be checked.

Use the template sections, fill in the description, check all prerequisite boxes, and select at least one type of change.

Maintainers can add the keep-open label to exempt a PR from this check.

Thank you for contributing! 🙏

@phillf

phillf commented Aug 25, 2026

Copy link
Copy Markdown
Author

I believe the template requirements should be met now.

@michelroegl-brunner

Copy link
Copy Markdown
Member

Nope. Fill it out yourself and dont let perplexity do it. Its a stupid model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(add-iptag): merge live IPv4 addresses for running LXCs

3 participants