new script ct/icinga by chrnie · Pull Request #1343 · community-scripts/ProxmoxVED

chrnie · 2026-01-27T16:08:19Z

✍️ Description

New Script for icinga

This will install a LXC container (debian) with

icinga2 Core as stand-alone master
local mariadb
local apache
icingadb and redis backend daemon
linuxfabrik plugins
icingaweb2 UI
- director module with kickstart baskets from linuxfabrik
- x509 certificate monitoring
  - additional director baskets for direct integration
  - optional scan a local network on 443 to kickstart this module
- reporting module
- map module
- proxmox integration module for director automation (unconfigured)
- perfdatagraphs (Grafana) (with external influxDB 1 or 2 backend)
- businessprocess module
- some themes

✅ Prerequisites (X in brackets)

Self-review completed – Code follows project standards.
Tested thoroughly – Changes work as expected.
No breaking changes – Existing functionality remains intact.
No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

🐞 Bug fix – Resolves an issue without breaking functionality.
✨ New feature – Adds new, non-breaking functionality.
💥 Breaking change – Alters existing functionality in a way that may require updates.
🆕 New script – A fully functional and tested script or script set.
🌍 Website update – Changes to website-related JSON files or metadata.
🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔍 Code & Security Review (X in brackets)

Follows Code_Audit.md & CONTRIBUTING.md guidelines
Uses correct script structure (AppName.sh, AppName-install.sh, AppName.json)
No hardcoded credentials

📋 Additional Information (optional)

needs a privileged container for some checks
using package repos from icinga, netways and Linuxfabrik

📦 Application Requirements (for new scripts)

Required for 🆕 New script submissions.
Pull requests that do not meet these requirements may be closed without review.

The application is at least 6 months old
The application is actively maintained
The application has 600+ GitHub stars
Official release tarballs are published

https://github.com/icinga/icinga2

greptile-apps · 2026-01-27T16:11:44Z

Greptile Overview

Greptile Summary

This PR adds a new Icinga2 monitoring system container setup with comprehensive installation including Icinga2 Core, IcingaDB, Icinga Web 2, and numerous pre-configured modules (Director, x509, Reporting, Notifications, Businessprocess). The implementation installs MariaDB and Apache locally, sets up multiple databases with generated passwords, and includes Linuxfabrik monitoring plugins for advanced monitoring scenarios.

Key Changes:

Added container setup script ct/icinga.sh with privileged container requirement for ping checks
Created comprehensive installation script install/icinga-install.sh with multi-stage setup for Icinga ecosystem
Added JSON metadata file with proper schema compliance
Includes optional InfluxDB integration for performance data and x509 certificate scanning

Issues Found:

Multiple style violations: uses git clone instead of the recommended fetch_and_deploy_gh_release function for stability
Uses deprecated apt-get instead of apt command
Incorrect license URL path (/ProxmoxVE/ should be /ProxmoxVED/)
Contains non-header comments in ct/icinga.sh which violate project standards
Unreachable code at line 310 in the installation script

Confidence Score: 3/5

This PR is functional but requires addressing multiple style violations and one logic issue before merging
The implementation is comprehensive and functionally sound, but has multiple violations of project coding standards (git clone usage, apt-get vs apt, improper comments, incorrect URLs) and contains unreachable code that should be fixed. These issues don't prevent the script from working but violate established best practices
Pay close attention to install/icinga-install.sh for the multiple git clone usages, unreachable break statement, and service enable pattern; and ct/icinga.sh for the non-header comments and license URL

Important Files Changed

Filename	Overview
ct/icinga.sh	Container setup script with minor style issues - incorrect license URL path and comments that should be removed
install/icinga-install.sh	Complex installation script with multiple style violations - uses `git clone` instead of `fetch_and_deploy_gh_release`, incorrect license URL, uses `apt-get` instead of `apt`, has unreachable code in line 310
frontend/public/json/icinga.json	Well-structured JSON metadata following all required schema fields with correct logo URL from selfh.st/icons CDN

greptile-apps

_{10 files reviewed, 10 comments}

_{Edit Code Review Agent Settings | Greptile}

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

chrnie

fixed all known problems from greptile.

A working fork can be used from here:
bash -c "$(curl -fsSL https://raw.githubusercontent.com/chrnie/ProxmoxVED/refs/heads/icingawrk/ct/icinga.sh)"

CrazyWolf13 · 2026-01-27T20:35:59Z

+msg_info "Adding Netways extras and plugins repository"
+setup_deb822_repo \
+  "netways-extras" \
+  "https://packages.netways.de/netways-repo.asc" \
+  "https://packages.netways.de/extras/debian/" \
+  "${VERSION_CODENAME}" \
+  "main"
+setup_deb822_repo \
+  "netways-plugins" \
+  "https://packages.netways.de/netways-repo.asc" \
+  "https://packages.netways.de/plugins/debian/" \
+  "${VERSION_CODENAME}" \
+  "main"
+msg_ok "Set up Netways Repositories"


Suggested change

msg_info "Adding Netways extras and plugins repository"

setup_deb822_repo \

"netways-extras" \

"https://packages.netways.de/netways-repo.asc" \

"https://packages.netways.de/extras/debian/" \

"${VERSION_CODENAME}" \

"main"

setup_deb822_repo \

"netways-plugins" \

"https://packages.netways.de/netways-repo.asc" \

"https://packages.netways.de/plugins/debian/" \

"${VERSION_CODENAME}" \

"main"

msg_ok "Set up Netways Repositories"

setup_deb822_repo \

"netways-extras" \

"https://packages.netways.de/netways-repo.asc" \

"https://packages.netways.de/extras/debian/" \

"${VERSION_CODENAME}" \

"main"

setup_deb822_repo \

"netways-plugins" \

"https://packages.netways.de/netways-repo.asc" \

"https://packages.netways.de/plugins/debian/" \

"${VERSION_CODENAME}" \

"main"

I think we have some code in tools.func for handling things like version codename etc, so no need to source them, right @MickLesk ?

CrazyWolf13 · 2026-01-27T20:36:58Z

+msg_info "Setting up Icinga Repository"
+setup_deb822_repo \
+  "icinga-stable" \
+  "https://packages.icinga.com/icinga.key" \
+  "https://packages.icinga.com/debian/" \
+  "icinga-${VERSION_CODENAME}" \
+  "main"
+msg_ok "Set up Icinga Repository"


Suggested change

msg_info "Setting up Icinga Repository"

setup_deb822_repo \

"icinga-stable" \

"https://packages.icinga.com/icinga.key" \

"https://packages.icinga.com/debian/" \

"icinga-${VERSION_CODENAME}" \

"main"

msg_ok "Set up Icinga Repository"

setup_deb822_repo \

"icinga-stable" \

"https://packages.icinga.com/icinga.key" \

"https://packages.icinga.com/debian/" \

"icinga-${VERSION_CODENAME}" \

"main"

CrazyWolf13 · 2026-01-27T20:45:15Z

+fetch_and_deploy_gh_release "pve" "nbuchwitz/icingaweb2-module-pve" "tarball" "latest" "/usr/share/icingaweb2/modules/pve"
+fetch_and_deploy_gh_release "check_pve" "nbuchwitz/check_pve"


those not inside an msg block

…out adding CREATE DATABASE IF NOT EXISTS to function

… module. I'll try to push that directly to the x509 project as you will ask me if it's possible to download it from somewhere

CrazyWolf13 · 2026-01-28T06:42:39Z

+MARIADB_DB_NAME="reporting" MARIADB_DB_USER="reporting" setup_mariadb_db
+REPORTING_DB_PW=$MARIADB_DB_PASS
+cat <<EOF | mariadb || { msg_error "Failed to alter databases"; exit 1; }
+ALTER DATABASE director CHARACTER SET utf8 COLLATE utf8_unicode_ci;


I think this should be default https://github.com/community-scripts/ProxmoxVED/blob/main/misc/tools.func#L3899

github-actions · 2026-02-08T20:21:34Z

This PR has been marked as stale. It will be closed if no new commits are added in 7 days.

github-actions · 2026-02-16T01:28:12Z

@chrnie Closing stale PR due to inactivity (no commits for 7 days after stale label).

chrnie added 3 commits January 27, 2026 16:27

dev stage

8776c40

use functions which exist only in ProxmoxVED

3521678

change source url to community-scripts/ProxmoxVED

3a5a25d

chrnie requested review from a team as code owners January 27, 2026 16:08

github-actions Bot added feature new script labels Jan 27, 2026

greptile-apps Bot reviewed Jan 27, 2026

View reviewed changes

chrnie and others added 5 commits January 27, 2026 17:16

Update License ct/icinga.sh

77ea90d

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

Enable service silently

4a5dfa7

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

Merge branch 'community-scripts:main' into feature/icinga_pr

dd5647a

use more best practices, where possible

ef1674b

fix License

fbb3bf7

chrnie commented Jan 27, 2026

View reviewed changes

Comment thread install/icinga-install.sh

Comment thread install/icinga-install.sh Outdated

Comment thread install/icinga-install.sh

Comment thread install/icinga-install.sh Outdated

Comment thread install/icinga-install.sh Outdated

Comment thread install/icinga-install.sh Outdated

CrazyWolf13 requested changes Jan 27, 2026

View reviewed changes

chrnie added 9 commits January 27, 2026 22:13

respect header style

6481af2

fix variable and last cli output

1f17212

using setup_mariadb_db, but director db must be set to utf8. Think ab…

fe4c508

…out adding CREATE DATABASE IF NOT EXISTS to function

base64 to plain json, custom director integration config for the x509…

e06fed0

… module. I'll try to push that directly to the x509 project as you will ask me if it's possible to download it from somewhere

remove old credentials, and replace pkg_update/pkg_install by apt-get

a8987a8

space inside the head

81a71bd

typo

1745b5b

proper escaping

4b7a3cd

handle credentials

38a6d00

CrazyWolf13 requested changes Jan 28, 2026

View reviewed changes

michelroegl-brunner force-pushed the main branch from 5e52452 to b5171d2 Compare February 3, 2026 15:07

CrazyWolf13 added the stale label Feb 8, 2026

github-actions Bot closed this Feb 16, 2026

		fetch_and_deploy_gh_release "pve" "nbuchwitz/icingaweb2-module-pve" "tarball" "latest" "/usr/share/icingaweb2/modules/pve"
		fetch_and_deploy_gh_release "check_pve" "nbuchwitz/check_pve"

Uh oh!

Uh oh!

Conversation

chrnie commented Jan 27, 2026

✍️ Description

✅ Prerequisites (X in brackets)

🛠️ Type of Change (X in brackets)

🔍 Code & Security Review (X in brackets)

📋 Additional Information (optional)

📦 Application Requirements (for new scripts)

Uh oh!

greptile-apps Bot commented Jan 27, 2026

Greptile Overview

Greptile Summary

Confidence Score: 3/5

Important Files Changed

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chrnie left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CrazyWolf13 Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

CrazyWolf13 Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

MickLesk Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CrazyWolf13 Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

CrazyWolf13 Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Feb 8, 2026

Uh oh!

github-actions Bot commented Feb 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chrnie left a comment •

edited

Loading