Add/kener - #1429
Conversation
This script sets up and updates the Kener application, managing Docker containers and providing access information.
This script installs Kener in a ProxmoxVE container, setting up dependencies, Docker, and the necessary folder structure and configuration files.
Added a JSON configuration file for Kener monitoring platform with details on installation, documentation, and system requirements.
Greptile OverviewGreptile SummaryThis PR adds Kener monitoring platform installation scripts for ProxmoxVE containers. The implementation uses Docker Compose to deploy Kener with PostgreSQL backend. Key changes:
Issues found:
Recommendations:
Confidence Score: 3/5
Important Files Changed
|
| @@ -0,0 +1,49 @@ | |||
| #!/usr/bin/env bash | |||
| source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVED/main/misc/build.func) | |||
| # Copyright (c) 2021-2026 danynocz | |||
There was a problem hiding this comment.
copyright should be community-scripts ORG, not individual author
| # Copyright (c) 2021-2026 danynocz | |
| # Copyright (c) 2021-2026 community-scripts ORG |
Context Used: Rule from dashboard - What: All shell scripts in ct/.sh or vm/.sh or tools//.sh must include a standardized header wit... (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| silent() { | ||
| "$@" >/dev/null 2>&1 | ||
| } |
There was a problem hiding this comment.
custom silent function reimplements $STD utility - use $STD instead
| silent() { | |
| "$@" >/dev/null 2>&1 | |
| } |
Context Used: Rule from dashboard - What: Use predefined utility functions from misc/tools.func instead of reimplementing common operati... (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| silent apt update | ||
| silent apt install -y git curl ca-certificates apt-transport-https openssl lsb-release gnupg |
There was a problem hiding this comment.
reinstalling preinstalled dependencies (curl, ca-certificates) wastes build time
| silent apt update | |
| silent apt install -y git curl ca-certificates apt-transport-https openssl lsb-release gnupg | |
| $STD apt install -y git apt-transport-https openssl lsb-release gnupg |
Context Used: Rule from dashboard - What: Installation scripts must not reinstall dependencies that are already preinstalled in the base... (source)
| silent apt update | ||
| silent apt install -y git curl ca-certificates apt-transport-https openssl lsb-release gnupg |
There was a problem hiding this comment.
use apt instead of apt-get per project standards
| silent apt update | |
| silent apt install -y git curl ca-certificates apt-transport-https openssl lsb-release gnupg | |
| $STD apt update | |
| $STD apt install -y git apt-transport-https openssl lsb-release gnupg |
Context Used: Rule from dashboard - What: Use apt instead of apt-get in scripts and documentation.
Why: apt provides a stable CLI... (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| msg_ok "Folder structure ready" | ||
|
|
||
| msg_info "Creating .env file" | ||
| cat <<EOF >/opt/kener/.env |
There was a problem hiding this comment.
heredoc delimiter should come before output redirection
| cat <<EOF >/opt/kener/.env | |
| cat <<EOF >/opt/kener/.env |
Context Used: Rule from dashboard - What: Heredoc syntax must come before the output redirection in cat commands.
Why: Placing the here... (source)
| msg_ok "Host IP: $HOST_IP" | ||
|
|
||
| msg_info "Creating Docker Compose file for Kener" | ||
| cat <<EOF >/opt/kener/docker-compose.yaml |
There was a problem hiding this comment.
heredoc delimiter should come before output redirection
| cat <<EOF >/opt/kener/docker-compose.yaml | |
| cat <<EOF >/opt/kener/docker-compose.yaml |
Context Used: Rule from dashboard - What: Heredoc syntax must come before the output redirection in cat commands.
Why: Placing the here... (source)
| "interface_port": 3000, | ||
| "documentation": "https://kener.ing/docs/home", | ||
| "website": "https://kener.ing", | ||
| "logo": "https://kener.ing/logo.png", |
There was a problem hiding this comment.
logo must use selfh.st/icons CDN format
| "logo": "https://kener.ing/logo.png", | |
| "logo": "https://cdn.jsdelivr.net/gh/selfhst/icons@main/webp/kener.webp", |
Context Used: Rule from dashboard - What: All JSON files must include a logo URL from the selfh.st/icons library using the exact CDN for... (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
✍️ Description
Added a fully functional Kener installation script for ProxmoxVE LXC containers in Docker. The script installs Docker, creates the required folder structure, generates a .env file with secret keys, sets up PostgreSQL, creates a Docker Compose file for Kener, and starts the containers.
✅ Prerequisites
🛠️ Type of Change
README,AppName.md,CONTRIBUTING.md, or other docs.🔍 Code & Security Review
Code_Audit.md&CONTRIBUTING.mdguidelinesAppName.sh,AppName-install.sh,AppName.json)📋 Images
📦 Application Requirements (for new scripts)