Skip to content

Add/kener - #1429

Closed
danielrydl wants to merge 5 commits into
community-scripts:mainfrom
danielrydl:add/kener
Closed

Add/kener#1429
danielrydl wants to merge 5 commits into
community-scripts:mainfrom
danielrydl:add/kener

Conversation

@danielrydl

Copy link
Copy Markdown

✍️ Description

Added a fully functional Kener installation script for ProxmoxVE LXC containers in Docker. The script installs Docker, creates the required folder structure, generates a .env file with secret keys, sets up PostgreSQL, creates a Docker Compose file for Kener, and starts the containers.

✅ Prerequisites

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No breaking changes – Existing functionality remains intact.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔍 Code & Security Review

  • Follows Code_Audit.md & CONTRIBUTING.md guidelines
  • Uses correct script structure (AppName.sh, AppName-install.sh, AppName.json)
  • No hardcoded credentials

📋 Images

image image

📦 Application Requirements (for new scripts)

Required for 🆕 New script submissions.
Pull requests that do not meet these requirements may be closed without review.

  • The application is at least 6 months old
  • The application is actively maintained
  • The application has 600+ GitHub stars
  • Official release tarballs are published
  • I understand that not all scripts will be accepted due to various reasons and criteria by the community-scripts ORG

This script sets up and updates the Kener application, managing Docker containers and providing access information.
This script installs Kener in a ProxmoxVE container, setting up dependencies, Docker, and the necessary folder structure and configuration files.
Added a JSON configuration file for Kener monitoring platform with details on installation, documentation, and system requirements.
@danielrydl
danielrydl requested review from a team as code owners February 7, 2026 21:04
@greptile-apps

greptile-apps Bot commented Feb 7, 2026

Copy link
Copy Markdown
Contributor

Greptile Overview

Greptile Summary

This PR adds Kener monitoring platform installation scripts for ProxmoxVE containers. The implementation uses Docker Compose to deploy Kener with PostgreSQL backend.

Key changes:

  • Adds ct/kener.sh container setup script with update functionality
  • Adds install/kener-install.sh Docker-based installation with auto-generated secrets
  • Adds frontend/public/json/kener.json metadata file

Issues found:

  • Copyright header in ct/kener.sh should use community-scripts ORG instead of individual author
  • Logo URL in JSON file must use the selfh.st/icons CDN format per project standards
  • Installation script has style issues: custom silent function instead of $STD, reinstalls preinstalled dependencies, and uses non-standard heredoc syntax
  • All heredoc statements should have delimiter before output redirection (<<EOF >file not >file <<EOF)

Recommendations:

  • Request Kener icon at selfh.st/icons repository if not available
  • Replace custom silent function with standard $STD utility
  • Remove preinstalled dependencies (curl, ca-certificates) from apt install
  • Fix heredoc syntax for consistency with codebase standards

Confidence Score: 3/5

  • Safe to merge after addressing style issues and logo URL format
  • The code is functionally correct and follows most project standards. However, there are several style violations that should be fixed: incorrect copyright header, non-standard logo URL, custom utility function instead of using standard tools, and heredoc syntax issues. The security implementation is sound with auto-generated secrets. No critical bugs or logic errors found.
  • Pay attention to frontend/public/json/kener.json (logo URL) and install/kener-install.sh (multiple style issues)

Important Files Changed

Filename Overview
ct/kener.sh Container setup script with minor copyright header issue; otherwise follows standards correctly
install/kener-install.sh Docker-based Kener installation with style issues: custom silent function, preinstalled dependencies, heredoc syntax
frontend/public/json/kener.json JSON metadata file with incorrect logo URL format - must use selfh.st/icons CDN

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, 7 comments

Edit Code Review Agent Settings | Greptile

Comment thread ct/kener.sh
@@ -0,0 +1,49 @@
#!/usr/bin/env bash
source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVED/main/misc/build.func)
# Copyright (c) 2021-2026 danynocz

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copyright should be community-scripts ORG, not individual author

Suggested change
# Copyright (c) 2021-2026 danynocz
# Copyright (c) 2021-2026 community-scripts ORG

Context Used: Rule from dashboard - What: All shell scripts in ct/.sh or vm/.sh or tools//.sh must include a standardized header wit... (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Comment thread install/kener-install.sh
Comment on lines +15 to +17
silent() {
"$@" >/dev/null 2>&1
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

custom silent function reimplements $STD utility - use $STD instead

Suggested change
silent() {
"$@" >/dev/null 2>&1
}

Context Used: Rule from dashboard - What: Use predefined utility functions from misc/tools.func instead of reimplementing common operati... (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Comment thread install/kener-install.sh
Comment on lines +20 to +21
silent apt update
silent apt install -y git curl ca-certificates apt-transport-https openssl lsb-release gnupg

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reinstalling preinstalled dependencies (curl, ca-certificates) wastes build time

Suggested change
silent apt update
silent apt install -y git curl ca-certificates apt-transport-https openssl lsb-release gnupg
$STD apt install -y git apt-transport-https openssl lsb-release gnupg

Context Used: Rule from dashboard - What: Installation scripts must not reinstall dependencies that are already preinstalled in the base... (source)

Comment thread install/kener-install.sh
Comment on lines +20 to +21
silent apt update
silent apt install -y git curl ca-certificates apt-transport-https openssl lsb-release gnupg

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use apt instead of apt-get per project standards

Suggested change
silent apt update
silent apt install -y git curl ca-certificates apt-transport-https openssl lsb-release gnupg
$STD apt update
$STD apt install -y git apt-transport-https openssl lsb-release gnupg

Context Used: Rule from dashboard - What: Use apt instead of apt-get in scripts and documentation.

Why: apt provides a stable CLI... (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Comment thread install/kener-install.sh
msg_ok "Folder structure ready"

msg_info "Creating .env file"
cat <<EOF >/opt/kener/.env

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heredoc delimiter should come before output redirection

Suggested change
cat <<EOF >/opt/kener/.env
cat <<EOF >/opt/kener/.env

Context Used: Rule from dashboard - What: Heredoc syntax must come before the output redirection in cat commands.

Why: Placing the here... (source)

Comment thread install/kener-install.sh
msg_ok "Host IP: $HOST_IP"

msg_info "Creating Docker Compose file for Kener"
cat <<EOF >/opt/kener/docker-compose.yaml

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heredoc delimiter should come before output redirection

Suggested change
cat <<EOF >/opt/kener/docker-compose.yaml
cat <<EOF >/opt/kener/docker-compose.yaml

Context Used: Rule from dashboard - What: Heredoc syntax must come before the output redirection in cat commands.

Why: Placing the here... (source)

"interface_port": 3000,
"documentation": "https://kener.ing/docs/home",
"website": "https://kener.ing",
"logo": "https://kener.ing/logo.png",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logo must use selfh.st/icons CDN format

Suggested change
"logo": "https://kener.ing/logo.png",
"logo": "https://cdn.jsdelivr.net/gh/selfhst/icons@main/webp/kener.webp",

Context Used: Rule from dashboard - What: All JSON files must include a logo URL from the selfh.st/icons library using the exact CDN for... (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@danielrydl danielrydl closed this Feb 7, 2026
@danielrydl
danielrydl deleted the add/kener branch February 7, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant