Add a kiwix installer. - #1448
Conversation
Greptile OverviewGreptile SummaryThis PR adds a new Kiwix LXC installer by introducing a CT build script ( However, several changes currently conflict with repo conventions/policies (JSON schema + icon URL requirements, apt/apt-get policy, service enable convention, comment restrictions in scripts) and there is a functional issue where the service fails to start on a fresh install if no Confidence Score: 2/5
Important Files Changed
|
4bc7ea6 to
8b1ec32
Compare
Kiwix serves offline Wikipedia, Project Gutenberg, and more from ZIM archives
8b1ec32 to
0139ead
Compare
|
This needs to be further discused. As there has been two releases In Dezember, the last release before that was over 1.5 Years ago. So i vote for waiting a bit longer if the app gets a more stable update schedule, then we can think ybout adding it. @community-scripts/contributor |
|
How is that relevant? It's a server for offline content with a stable data format and has ~800 stars on github. The content (eg archive of wikipedia) is updated fairly regularly, but the server doesn't need to be. Still, it's good to have a nice proxmox installer for those who want to serve the content. If there is a similarly trivial way to create a LXC, mount a directory readonly, install it from apt and set up a service, then maybe the correct answer is to point people at that instead, but I don't know of such a trivial way and apt is out of date. |
|
I have nothing against it, there are commits, the app has two new releases and sometimes an app just reaches a somewhat polished app (though there is always room for more, which is not always neccessary) We have apps in our catalogue with far far less updates and unstable release shedules. I see no reason to not accept such a contribution. |
| msg_ok "Container Options Set" | ||
|
|
||
| msg_ok "Completed Successfully!\n" | ||
| IP=$(pct exec $CTID -- hostname -I | awk '{print $1}') |
There was a problem hiding this comment.
there is $LOCAL_IP made available by our core funcs
| fi | ||
|
|
||
| msg_info "Setting Container Options" | ||
| pct set $CTID --onboot 1 |
There was a problem hiding this comment.
was this even tested?
pct will not work when executing the update, as it runs from within the LXC
| echo -e "${TAB}${GATEWAY}${BGN}Web Interface:${CL} ${BL}http://${IP}:8080${CL}" | ||
| echo -e "${TAB}${INFO}${BGN}ZIM Directory:${CL} ${ZIM_DIR} ${DGN}→${CL} ${BGN}/data${CL}" |
There was a problem hiding this comment.
Please stick to our default ending.
|
@tewalds This PR has been marked as stale. It will be closed if no new commits are added in 7 days. |
|
My server is down for the next week or two as I move house, but will come back to this when I have a working server again. |
|
@tewalds Closing stale PR due to inactivity (no commits for 7 days after stale label). |
|
@tewalds Feel free to reopen once you have time again. |
Scripts which are clearly AI generated and not further revised by the Author of this PR (in terms of Coding Standards and Script Layout) may be closed without review.
✍️ Description
Add a kiwix installer. Kiwix serves offline content, for example wikipedia.
https://kiwix.org/
https://github.com/kiwix/kiwix-tools
🔗 Related PR / Issue
Fixes #1855
✅ Prerequisites (X in brackets)
🛠️ Type of Change (X in brackets)
README,AppName.md,CONTRIBUTING.md, or other docs.🔍 Code & Security Review (X in brackets)
Code_Audit.md&CONTRIBUTING.mdguidelinesAppName.sh,AppName-install.sh,AppName.json)📋 Additional Information (optional)
📦 Application Requirements (for new scripts)