Skip to content

New lxc : Langflow - #1489

Closed
YamonBot wants to merge 5 commits into
community-scripts:mainfrom
yamonco:feat/langflow-helper-script
Closed

New lxc : Langflow#1489
YamonBot wants to merge 5 commits into
community-scripts:mainfrom
yamonco:feat/langflow-helper-script

Conversation

@YamonBot

@YamonBot YamonBot commented Feb 21, 2026

Copy link
Copy Markdown

✍️ Description

Add a new Langflow script set for ProxmoxVED testing:

  • ct/langflow.sh
  • install/langflow-install.sh
  • frontend/public/json/langflow.json

The script follows the standard CT/install/json layout, uses systemd for service management, and supports update flow through the CT script.

🔗 Related PR / Issue

Link: #

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No breaking changes – Existing functionality remains intact.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔍 Code & Security Review (X in brackets)

  • Follows Code_Audit.md & CONTRIBUTING.md guidelines
  • Uses correct script structure (AppName.sh, AppName-install.sh, AppName.json)
  • No hardcoded credentials

📋 Additional Information (optional)


📦 Application Requirements (for new scripts)

Required for 🆕 New script submissions.
Pull requests that do not meet these requirements may be closed without review.

  • The application is at least 6 months old
  • The application is actively maintained
  • The application has 600+ GitHub stars
  • Official release tarballs are published
  • I understand that not all scripts will be accepted due to various reasons and criteria by the community-scripts ORG

@greptile-apps

greptile-apps Bot commented Feb 21, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds a complete Langflow script set (CT, install, and JSON) following ProxmoxVED conventions with systemd service management and comprehensive update/rollback logic.

Major changes:

  • New ct/langflow.sh with sophisticated update logic, health checks, and rollback functionality
  • New install/langflow-install.sh using uv for Python dependency management with PyTorch CPU-only installation
  • New frontend/public/json/langflow.json with complete metadata and user warnings about installation time
  • Uses Python 3.12 virtual environment with configurable concurrency settings for package installation
  • Implements secure credential generation and proper file permissions for sensitive configuration

Issues found:

  • One critical error suppression pattern (|| exit) in install/langflow-install.sh:42 that must be removed per project standards

Confidence Score: 4/5

  • This PR is safe to merge with one small fix required
  • The implementation is solid with excellent error handling and follows project conventions closely. The only issue is a single line using || exit which violates error handling standards and must be removed. After this fix, the code will be production-ready.
  • Pay attention to install/langflow-install.sh:42 - remove the || exit pattern before merging

Important Files Changed

Filename Overview
ct/langflow.sh New CT script with comprehensive update logic, proper error handling, and rollback functionality - follows all conventions
install/langflow-install.sh Clean install script with proper structure and dependency handling - one critical error suppression issue found
frontend/public/json/langflow.json Well-structured JSON metadata with proper schema, logo URL, and comprehensive notes - fully compliant

Last reviewed commit: 6b211ca

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, 5 comments

Edit Code Review Agent Settings | Greptile

Comment thread ct/langflow.sh Outdated
@@ -0,0 +1,168 @@
#!/usr/bin/env bash
source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/build.func)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incorrect repository URL - should be ProxmoxVED not ProxmoxVE

Suggested change
source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/build.func)
source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVED/main/misc/build.func)

Comment thread ct/langflow.sh Outdated
source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/build.func)
# Copyright (c) 2021-2026 community-scripts ORG
# Author: Yamon
# License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incorrect repository URL - should be ProxmoxVED not ProxmoxVE

Suggested change
# License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
# License: MIT | https://github.com/community-scripts/ProxmoxVED/raw/main/LICENSE

Comment thread install/langflow-install.sh Outdated

# Copyright (c) 2021-2026 community-scripts ORG
# Author: Yamon
# License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incorrect repository URL - should be ProxmoxVED not ProxmoxVE

Suggested change
# License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
# License: MIT | https://github.com/community-scripts/ProxmoxVED/raw/main/LICENSE

Comment thread install/langflow-install.sh Outdated
Comment on lines +131 to +132
systemctl daemon-reload
systemctl enable -q --now langflow

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove daemon-reload per project standards - systemctl enable -q --now handles service activation

Suggested change
systemctl daemon-reload
systemctl enable -q --now langflow
systemctl enable -q --now langflow

Context Used: Rule from dashboard - What: All service creation must use systemctl enable -q --now to start and enable services in a si... (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Comment thread install/langflow-install.sh Outdated
Comment on lines +16 to +21
msg_info "Installing Dependencies"
if ! install_packages_with_retry \
build-essential \
python3-dev \
curl \
git; then

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verify curl and git aren't preinstalled in base image - if they are, remove them from dependencies per project standards

Context Used: Rule from dashboard - What: Installation scripts must not reinstall dependencies that are already preinstalled in the base... (source)

@YamonBot YamonBot closed this Feb 21, 2026
@YamonBot YamonBot reopened this Feb 21, 2026
@YamonBot YamonBot changed the title feat(langflow): add langflow ct/install script and metadata New lxc : Langflow Feb 21, 2026
@YamonBot YamonBot closed this Feb 23, 2026
@YamonBot YamonBot reopened this Feb 23, 2026

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Comment thread install/langflow-install.sh
@YamonBot
YamonBot marked this pull request as draft February 23, 2026 12:56
@YamonBot YamonBot closed this Feb 23, 2026
@YamonBot YamonBot reopened this Feb 23, 2026
@github-actions

github-actions Bot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

@YamonBot This PR has been marked as stale. It will be closed if no new commits are added in 7 days.

@YamonBot YamonBot closed this Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants