New lxc : Langflow - #1489
Conversation
Greptile SummaryAdds a complete Langflow script set (CT, install, and JSON) following ProxmoxVED conventions with systemd service management and comprehensive update/rollback logic. Major changes:
Issues found:
Confidence Score: 4/5
Important Files Changed
Last reviewed commit: 6b211ca |
| @@ -0,0 +1,168 @@ | |||
| #!/usr/bin/env bash | |||
| source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/build.func) | |||
There was a problem hiding this comment.
incorrect repository URL - should be ProxmoxVED not ProxmoxVE
| source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/build.func) | |
| source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVED/main/misc/build.func) |
| source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/build.func) | ||
| # Copyright (c) 2021-2026 community-scripts ORG | ||
| # Author: Yamon | ||
| # License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE |
There was a problem hiding this comment.
incorrect repository URL - should be ProxmoxVED not ProxmoxVE
| # License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE | |
| # License: MIT | https://github.com/community-scripts/ProxmoxVED/raw/main/LICENSE |
|
|
||
| # Copyright (c) 2021-2026 community-scripts ORG | ||
| # Author: Yamon | ||
| # License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE |
There was a problem hiding this comment.
incorrect repository URL - should be ProxmoxVED not ProxmoxVE
| # License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE | |
| # License: MIT | https://github.com/community-scripts/ProxmoxVED/raw/main/LICENSE |
| systemctl daemon-reload | ||
| systemctl enable -q --now langflow |
There was a problem hiding this comment.
remove daemon-reload per project standards - systemctl enable -q --now handles service activation
| systemctl daemon-reload | |
| systemctl enable -q --now langflow | |
| systemctl enable -q --now langflow |
Context Used: Rule from dashboard - What: All service creation must use systemctl enable -q --now to start and enable services in a si... (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| msg_info "Installing Dependencies" | ||
| if ! install_packages_with_retry \ | ||
| build-essential \ | ||
| python3-dev \ | ||
| curl \ | ||
| git; then |
There was a problem hiding this comment.
verify curl and git aren't preinstalled in base image - if they are, remove them from dependencies per project standards
Context Used: Rule from dashboard - What: Installation scripts must not reinstall dependencies that are already preinstalled in the base... (source)
|
@YamonBot This PR has been marked as stale. It will be closed if no new commits are added in 7 days. |
✍️ Description
Add a new Langflow script set for ProxmoxVED testing:
ct/langflow.shinstall/langflow-install.shfrontend/public/json/langflow.jsonThe script follows the standard CT/install/json layout, uses systemd for service management, and supports update flow through the CT script.
🔗 Related PR / Issue
Link: #
✅ Prerequisites (X in brackets)
🛠️ Type of Change (X in brackets)
README,AppName.md,CONTRIBUTING.md, or other docs.🔍 Code & Security Review (X in brackets)
Code_Audit.md&CONTRIBUTING.mdguidelinesAppName.sh,AppName-install.sh,AppName.json)📋 Additional Information (optional)
📦 Application Requirements (for new scripts)