Skip to content

Make sure variant env var names are valid (fixes #5862) #5863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pauldmccarthy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make sure variant env var names are valid (fixes #5862) #5863

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion conda_build/environ.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import os
import platform
import re
import string
import subprocess
import sys
import warnings
Expand Down Expand Up @@ -376,10 +377,23 @@ def get_dict(
# features
d.update({feat.upper(): str(int(value)) for feat, value in feature_list})

# Make sure env vars generated from variants have valid names
def sanitize(varname):
sanitized = ''
if varname[0] not in string.ascii_letters + '_':
sanitized += '_'
allowed = string.ascii_letters + string.digits + '_'
for char in varname:
if char in allowed:
sanitized += char
else:
sanitized += '_'
return sanitized

variant = variant or m.config.variant
for k, v in variant.items():
if not for_env or (k.upper() not in d and k.upper() not in LANGUAGES):
d[k] = v
d[sanitize(k)] = v
return d


Expand Down