fix: enforce IO concurrency for metadata reading#2230
Open
Overproness wants to merge 1 commit intoconda:mainfrom
Open
fix: enforce IO concurrency for metadata reading#2230Overproness wants to merge 1 commit intoconda:mainfrom
Overproness wants to merge 1 commit intoconda:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2021
The IO concurrency limits (configured via
InstallDriver) were only being respected during individual file linking operations, not during the reading ofindex.jsonandpaths.jsonmetadata at the start of each package installation.When installing many packages concurrently:
link_packagefunction ininstaller/mod.rsspawned hundreds of rayon tasks simultaneouslylink_package_sync, which immediately readsindex.jsonandpaths.jsonfrom disk with no throttlingulimitvaluesSolution: Acquire an IO permit from the
InstallDriverbefore spawning each rayon task. The permit is held for the entire duration of the synchronous linking operation (including metadata reads), ensuring that at mostio_concurrency_limitpackages (default 100) perform IO-intensive operations concurrently.The fix is minimal and non-disruptive:
link_package_syncAPI unchangedOwnedSemaphorePermitwhich isSend + 'staticand moves cleanly into the rayon closureHow Has This Been Tested?
cargo check -p rattlerpasses with no errorscargo test -p rattlerpasses all 53 relevant install tests on WSL UbuntuAI Disclosure
Checklist: