feat: Add Python bindings to PrefixData#2267
Open
jaimergp wants to merge 3 commits intoconda:mainfrom
Open
Conversation
jaimergp
commented
Mar 20, 2026
|
|
||
| match record { | ||
| Some(Ok(record)) => Ok(Some(record.clone().into())), | ||
| // TODO: Expose underlying error |
Contributor
Author
There was a problem hiding this comment.
I don't know how to deal with this. PrefixDataError cannot be converted to PyRattlerError so I assume we need some extra wiring, but I don't know where that goes.
Collaborator
There was a problem hiding this comment.
I think it can go in this struct:
rattler/py-rattler/src/error.rs
Line 23 in 8f06175
Collaborator
There was a problem hiding this comment.
So you could maybe add a explicit mapping or use the #[from] value like in other cases? .map_err can be useful to map between error types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Python bindings were missing in #2074
How Has This Been Tested?
See doctests
AI Disclosure
Tools: {e.g., Claude, Codex, GitHub Copilot, ChatGPT, etc.}
Checklist: