fix: normalize channel names to canonical URLs using ChannelConfig#2295
Draft
ritankarsaha wants to merge 1 commit intoconda:mainfrom
Draft
fix: normalize channel names to canonical URLs using ChannelConfig#2295ritankarsaha wants to merge 1 commit intoconda:mainfrom
ritankarsaha wants to merge 1 commit intoconda:mainfrom
Conversation
716bb62 to
74fc431
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a channel_config: ChannelConfig field to SolverTask (defaulting to the standard conda.anaconda.org alias for backward compatibility) and threads it through to
CondaDependencyProvider::new.The TODO block that previously just collected channel-pinned specs is replaced by apre-computation step that maps each spec to its canonical channel URL, re-expanding short names through the caller-provided config. During per-record filtering, record.channel is likewise normalized through the same config before comparison. This ensures that a spec like my-channel::numpy correctly matches or rejects records regardless of which channel alias was active when the MatchSpec was parsed.
Fixes #2294
Checklist:
@baszalmstra