feat: add tracing instrumentation for upload throughput#2307
Open
maniktyagi04 wants to merge 4 commits intoconda:mainfrom
Open
feat: add tracing instrumentation for upload throughput#2307maniktyagi04 wants to merge 4 commits intoconda:mainfrom
maniktyagi04 wants to merge 4 commits intoconda:mainfrom
Conversation
Closes conda#2280 Previously, the OCI manifest HTTP response was not checked for a successful status code before attempting to deserialize the body as JSON. This caused confusing deserialization errors to surface when the server returned a non-2xx status code (e.g., 404 Not Found, 403 Forbidden), completely hiding the real underlying cause. This fix mirrors the existing pattern already used in the function in the same file: .error_for_status() .map_err(OciMiddlewareError::Reqwest)? The response variable is also renamed from to to make the two-step flow (check status, then deserialize) clearer to future readers. The stale TODO comment is also removed since the error is now properly handled.
This addresses Issue conda#2287 by ensuring that PathsJson entries are always sorted by their relative path during construction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2306