fix: handle all shells in run_in_environment#2315
Open
ritankarsaha wants to merge 1 commit intoconda:mainfrom
Open
fix: handle all shells in run_in_environment#2315ritankarsaha wants to merge 1 commit intoconda:mainfrom
ritankarsaha wants to merge 1 commit intoconda:mainfrom
Conversation
fix(rattler_shell): handle all shells in run_in_environment
ritankarsaha
force-pushed
the
fix/run-in-environment-unsupported-shells
branch
from
40806c3 to
f36036f
Compare
Contributor
Author
|
@baszalmstra fixed CI fails, can you take a look into this once ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes - users on Zsh/Fish/PowerShell/NuShell/Xonsh hitting a runtime panic when pixi calls
run_in_environment.Replaced the
unimplemented!()panic with proper invocations for Zsh, Fish, Xonsh, NuShell (script as positional arg) and PowerShell (-Fileflag). AddRunError::UnsupportedShellvariant.Fixes #2314
Checklist:
@baszalmstra