fix: only retry transient I/O errors in should_retry()#2317
Open
ritankarsaha wants to merge 1 commit intoconda:mainfrom
Open
fix: only retry transient I/O errors in should_retry()#2317ritankarsaha wants to merge 1 commit intoconda:mainfrom
ritankarsaha wants to merge 1 commit intoconda:mainfrom
Conversation
ritankarsaha
force-pushed
the
fix/should-retry-transient-io-errors
branch
from
2e1eb16 to
f3ddde0
Compare
…ould_retry() Signed-off-by: RITANKAR SAHA <ritankar.saha786@gmail.com> fix(rattler_package_streaming): only retry transient I/O errors in should_retry() fix(rattler_package_streaming): only retry transient I/O errors in should_retry()
ritankarsaha
force-pushed
the
fix/should-retry-transient-io-errors
branch
from
f3ddde0 to
2228d7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
should_retry()was returningtruefor allIoErrorandCouldNotCreateDestinationvariants, regardless of error kindPermissionDenied,NotFound, andOtherwould retry forever — the TODO comment in the code also acknowledged this was wrongerr.kind()and only retries genuinely transient kinds:BrokenPipe,ConnectionReset,ConnectionAborted,ConnectionRefused,NotConnected,TimedOut,UnexpectedEof,InterruptedCouldNotCreateDestinationwith a transient error kindFixes #2316
Checklist:
@baszalmstra what do you think ? Any more changes required?