Fix/agent execution diagram fixes - #1515
Conversation
…add Expand control (conductor-oss#1452)
…uctor-oss#1514) Sort column was remapped to a nonexistent workflowName field, which no backend indexes, so ASC/DESC returned rows in the same order.
|
Confirmed this is the right fix — Worth noting the failure mode differs by backend, which may explain the "unreliable" framing in #1514. On sqlite/postgres the sort field is dropped silently and rows come back in query-plan order. On Elasticsearch the unmapped field is rejected outright — verified against a live ES-backed server: So on ES deployments the page fails to load entirely rather than mis-ordering. I opened #1518 with tests-only coverage pinning that contract in both query builders, to complement this PR — no overlap with your changes. |
Pull Request type
Changes in this PR
Sorting by Agent Name / Workflow Name was unreliable — clicking ascending or descending returned the same row order. The sort handler remapped the column's
workflowTypeid toworkflowName, a field no backend (sqlite/postgres/ES) indexes, so the sort param was silently dropped. Fixed in Agent Executions, Workflow Executions, and Task Search (same bug was copy-pasted into all three).Before / After
Issue #1514
Alternatives considered
Keeping
workflowNameas the wire format and adding it as an accepted field alias in each persistence backend's query builder (sqlite, Postgres, ES) instead of fixing the UI. Rejected — more surface area to keep in sync across four backends versus a one-line fix at the single place the wrong name originates.