Skip to content

test(persistence): pin the sort-field contract behind #1514 #1518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manan164 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(persistence): pin the sort-field contract behind #1514 #1518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions ...ence/src/test/java/com/netflix/conductor/postgres/util/PostgresIndexQueryBuilderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -725,4 +725,26 @@ void shouldGenerateQueryForParentWorkflowId() throws SQLException {
inOrder.verify(mockQuery).addParameter(0);
verifyNoMoreInteractions(mockQuery);
}

@Test
void shouldSortOnWorkflowTypeWhichBacksTheAgentNameColumn() throws SQLException {
PostgresIndexQueryBuilder builder =
new PostgresIndexQueryBuilder(
"workflow_index", "", "", 0, 15, List.of("workflowType:ASC"), properties);
assertEquals(
"SELECT json_data::TEXT FROM workflow_index ORDER BY workflow_type ASC LIMIT ? OFFSET ?",
builder.getQuery());
}

@Test
void shouldDropSortFieldsThatAreNotIndexedColumns() throws SQLException {
// A sort field outside VALID_FIELDS produces no ORDER BY at all rather than an
// error, so LIMIT/OFFSET pages an unordered result set. Callers must send the
// indexed column name -- `workflowType`, not `workflowName`. See issue #1514.
PostgresIndexQueryBuilder builder =
new PostgresIndexQueryBuilder(
"workflow_index", "", "", 0, 15, List.of("workflowName:ASC"), properties);
assertEquals(
"SELECT json_data::TEXT FROM workflow_index LIMIT ? OFFSET ?", builder.getQuery());
}
}
21 changes: 21 additions & 0 deletions ...sistence/src/test/java/com/netflix/conductor/sqlite/util/SqliteIndexQueryBuilderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,4 +257,25 @@ void shouldGenerateQueryForParentWorkflowId() throws SQLException {
inOrder.verify(mockQuery).addParameter(0);
verifyNoMoreInteractions(mockQuery);
}

@Test
void shouldSortOnWorkflowTypeWhichBacksTheAgentNameColumn() throws SQLException {
SqliteIndexQueryBuilder builder =
new SqliteIndexQueryBuilder(
"workflow_index", "", "", 0, 15, List.of("workflowType:ASC"), properties);
assertEquals(
"SELECT json_data FROM workflow_index ORDER BY workflow_type ASC LIMIT ? OFFSET ?",
builder.getQuery());
}

@Test
void shouldDropSortFieldsThatAreNotIndexedColumns() throws SQLException {
// A sort field outside VALID_FIELDS produces no ORDER BY at all rather than an
// error, so LIMIT/OFFSET pages an unordered result set. Callers must send the
// indexed column name -- `workflowType`, not `workflowName`. See issue #1514.
SqliteIndexQueryBuilder builder =
new SqliteIndexQueryBuilder(
"workflow_index", "", "", 0, 15, List.of("workflowName:ASC"), properties);
assertEquals("SELECT json_data FROM workflow_index LIMIT ? OFFSET ?", builder.getQuery());
}
}
Loading