Fix docs deploy: make main.py importable in the mkdocs container - #1558
Open
v1r3n wants to merge 22 commits into
Open
Fix docs deploy: make main.py importable in the mkdocs container#1558v1r3n wants to merge 22 commits into
v1r3n wants to merge 22 commits into
Conversation
mkdocs.yml declares the mermaid custom fence as
`!!python/name:main.mermaid_fence`, which PyYAML resolves with a plain
`import main` while parsing the config. The deploy action runs the mkdocs
console script inside a Docker container, where sys.path[0] is the script's
bin directory rather than the checkout, so the import fails and the deploy
aborts before building.
Point PYTHONPATH at the container's workspace mount so main.py resolves.
Run 32411004435 failed with:
cannot find module 'main' (No module named 'main')
in "/github/workspace/mkdocs.yml", line 283, column 19
- new step in publish.yml points the conductor-oss org's CONDUCTOR_SERVER_VERSION variable at the just-published version - runs after Maven Central publish succeeds, covers RC and stable releases - org variable falls back for java-sdk, javascript-sdk, python-sdk, csharp-sdk e2e workflows without a per-repo write
Workflow diagram 'Export to image' has multiple issues (unresponsive, draft export fails, switch node unreadable)
* https://orkes.atlassian.net/browse/CCOR-13363 Improve Queue Monitor filter UX * Don't make so many fetches when using queue monitor quick search * Avoid using sx unless it's for overrides * Update tests
…ent returnStrategy options (#1579)
Import BPMN feature is not easily discoverable on Workflow Definitions page
* fix(ui): schedule search API, overwrite on edit, and self-contained clone dialog Use /scheduler/schedules/search for schedule lists; overwrite=true on edit saves; clone dialog owns the save mutation and handles 409 via form state. Migrate schedulerHooks to TypeScript. * Instead of fetching all schedules for the clone dialog, check for existing schedule when doing clone save * Use shorter error message * https://orkes.atlassian.net/browse/CCOR-12995 Add colors for new Schedule manager role * - Update roles to use lookup for colors instead of if statements - Convert orkes-theme to ts and simplify to use hex colors - Remove unused globalConstants
…letion (#1596) * Docs: describe the current Executions search UI and document reasonForIncompletion * Docs: drop the localhost link from the Executions search step
Co-authored-by: Naomi Most <naomi.most@orkes.io>
Adds support for schema registry to workflows and tasks.
…) (#1598) * fix(deps): bump netty to 4.1.136.Final and micrometer to 1.15.12 (#1528) Resolves the remaining high-severity Java CVEs flagged in #1528: - netty 4.1.135.Final -> 4.1.136.Final CVE-2026-56819 (netty-codec-http2), CVE-2026-55831/55833/56745 (netty-codec-http), CVE-2026-59901 (netty-codec) - micrometer-core 1.15.11 -> 1.15.12 via revMicrometer + a BOM override CVE-2026-40983, CVE-2026-40984 micrometer-core was resolved to 1.15.11 by the Spring Boot BOM while the explicitly-declared registry artifacts were pinned at revMicrometer=1.14.6. Bumping revMicrometer to 1.15.12 and adding ext['micrometer.version'] = revMicrometer keeps core and the registries aligned on the patched version. * fix(deps): keep micrometer registries on 1.14.6 to preserve protobuf 3.x Bumping the whole micrometer family to 1.15.12 pulled micrometer-registry-otlp 1.15.x, which brings opentelemetry-proto 1.5.0-alpha. That gencode requires protobuf-java 4.x (com.google.protobuf.RuntimeVersion$RuntimeDomain), but protobuf-java is pinned to 3.25.5 (#964, GraalVM), so OtlpMeterRegistry failed at runtime with NoClassDefFoundError and OtlpMetricsConfigurationTest broke. Decouple the versions: micrometer-core still bumps to 1.15.12 (the CVE fix, via the BOM property), while the registry artifacts (otlp/cloudwatch2/azure-monitor/ prometheus) stay on 1.14.6 -> opentelemetry-proto 1.3.2-alpha (protobuf 3.x). This matches the working main baseline for the registries.
…o sentinels by default (#1578) * feat(redis-sentinel): add conductor.redis.sentinelPassword, no AUTH to sentinels by default Sentinels without requirepass reject AUTH (Jedis 6 has no tolerance for the error reply). Gate sentinel credentials behind an explicit property, matching Spring/Lettuce sentinel.password semantics. Master auth still comes from the 4th segment of conductor.redis.hosts. * docs(redis-configuration): document sentinel-password, fix stale sentinel auth description - Rewrite the RedisSentinelConfiguration bullet that still described the pre-#1578 behavior (sentinels reusing the data-node password) - Add sentinel-password row to the connection properties table - Show the property in the Sentinel quick-start example - Correct ignore-ssl scope: honored in cluster and sentinel modes, not cluster only (verified against createBaseClientConfigBuilder) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: jrnie <jrnie@iflytek.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: Viren Baraiya <virenx@gmail.com> Co-authored-by: Naomi Most <naomi.most@orkes.io>
* Add size-based reviewer requirement workflow Require 2 approvals for PRs that change >= 2000 lines (excluding generated, vendored, and binary files); 1 approval otherwise. Enforced via a required status check since branch protection can't vary the approval count by diff size. * Only fail the size check for large PRs missing the extra approval A review gate that shows a red X on every unapproved PR reads like a broken test and discourages reviewers before they engage. The baseline 1-approval requirement is already enforced by native branch protection (shown as GitHub's normal 'Review required' UI), so this check now passes green for normal-size PRs and only turns red for large PRs (>= 2000 lines) that still need the second approval. * Separate review-policy signal from CI: rename check, add label + sticky comment Rework the size-based approval gate so its signal can't be mistaken for a broken test: - Rename the check to 'review-policy / approvals' so a red row reads as a review gate, not a CI/test failure. - Surface the requirement primarily as a 'needs: N approvals' label and a sticky PR comment, so reviewers see it in the labels/timeline rather than only in the checks row. Labels and comment are cleared when satisfied. - Switch the PR trigger to pull_request_target so the token is writable on fork PRs (needed for label/comment management). The workflow never checks out or executes PR code, so this is safe. The blocking check still gates merge for large PRs (>= 2000 lines) missing the extra approval; normal-size PRs stay green (baseline handled by native branch protection).
github-actions
Bot
added
size: XL
|
👥 Review policy — action needed. This PR changes 13,795 lines, which crosses the large-PR threshold (2,000). Large PRs require 2 approvals; it currently has 0. 2 more to go. This is a review-policy gate, not a CI/test failure — see the |
…r hard-errors (#1603) The repo's default workflow token is read-only, so the label + comment API calls (issues: write) return 403. Because those calls threw, the whole review-policy job errored on every PR -- including small PRs whose only action was clearing a stale label in the cleanup path. Wrap the label/comment helpers so a denied write logs a warning and continues instead of throwing. The merge gate is enforced purely by the check's pass/fail status (setFailed), which needs no write access, so it keeps working; the label/comment become a best-effort convenience that lights up automatically if the repo grants the token write access.
* docs(ai): replace deprecated dall-e-3 with gpt-image-1 Signed-off-by: milan-oscard-8561 <milan-oscard-8561@users.noreply.github.com> * docs(ai): replace deprecated dall-e-3 with gpt-image-1 Signed-off-by: milan-oscard-8561 <milan-oscard-8561@users.noreply.github.com> * docs(ai): replace deprecated dall-e-3 with gpt-image-1 Signed-off-by: milan-oscard-8561 <milan-oscard-8561@users.noreply.github.com> * docs(ai): replace deprecated dall-e-3 with gpt-image-1 Signed-off-by: milan-oscard-8561 <milan-oscard-8561@users.noreply.github.com> * docs(ai): replace deprecated dall-e-3 with gpt-image-1 Signed-off-by: milan-oscard-8561 <milan-oscard-8561@users.noreply.github.com> * fix(examples): use gpt-image-1 landscape size 1536x1024 Signed-off-by: braxtonzhangio <braxtonzhangio@users.noreply.github.com> * docs(ai): use valid gpt-image-1 landscape size Signed-off-by: braxtonzhangio <braxtonzhangio@users.noreply.github.com> * docs(examples): replace remaining DALL-E wording Signed-off-by: braxtonzhangio <braxtonzhangio@users.noreply.github.com> --------- Signed-off-by: milan-oscard-8561 <milan-oscard-8561@users.noreply.github.com> Signed-off-by: braxtonzhangio <braxtonzhangio@users.noreply.github.com> Co-authored-by: milan-oscard-8561 <milan-oscard-8561@users.noreply.github.com> Co-authored-by: Naomi Most <naomi.most@orkes.io> Co-authored-by: braxtonzhangio <braxtonzhangio@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mkdocs.yml declares the mermaid custom fence as
!!python/name:main.mermaid_fence, which PyYAML resolves with a plainimport mainwhile parsing the config. The deploy action runs the mkdocs console script inside a Docker container, where sys.path[0] is the script's bin directory rather than the checkout, so the import fails and the deploy aborts before building.Point PYTHONPATH at the container's workspace mount so main.py resolves.
Run 32411004435 failed with:
cannot find module 'main' (No module named 'main')
in "/github/workspace/mkdocs.yml", line 283, column 19
Pull Request type
NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Describe the new behavior from this PR, and why it's needed
Issue #
Alternatives considered
Describe alternative implementation you have considered
Enterprise UI Playwright Tests
Every PR automatically triggers the enterprise UI Playwright E2E test suite.
Tests run against conductor-ui
mainby default. To test against a differentconductor-ui branch, add this line anywhere in the PR description: