Skip to content

Fix class name for JAAS login module in Jetty 12 - #2599

Open
Francisco Robles Martín (froblesmartin) wants to merge 1 commit into
confluentinc:masterfrom
froblesmartin:froblesmartin-patch-1
Open

Fix class name for JAAS login module in Jetty 12#2599
Francisco Robles Martín (froblesmartin) wants to merge 1 commit into
confluentinc:masterfrom
froblesmartin:froblesmartin-patch-1

Conversation

@froblesmartin

@froblesmartin Francisco Robles Martín (froblesmartin) commented Jun 24, 2026

Copy link
Copy Markdown
Member

Description

C3 Next Gen uses Jetty 12, and the PropertyFileLoginModule class has changed to: https://github.com/jetty/jetty.project/blob/jetty-12.1.x/jetty-core/jetty-security/src/main/java/org/eclipse/jetty/security/jaas/spi/PropertyFileLoginModule.java

Before, on Jetty 11 and previous, it was located at https://github.com/jetty/jetty.project/blob/jetty-11.0.x/jetty-jaas/src/main/java/org/eclipse/jetty/jaas/spi/PropertyFileLoginModule.java

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

TBD

Checklist:

  • Any variable/code changes have been validated to be backwards compatible (doesn't break upgrade)
  • I have added tests that prove my fix is effective or that my feature works
  • If required, I have ensured the changes can be discovered by cp-ansible discovery codebase
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the JAAS login module class reference used by Control Center Next Gen to match the package name used in Jetty 12, ensuring JAAS authentication can load the PropertyFileLoginModule correctly in Jetty 12-based deployments.

Changes:

  • Update the JAAS config template to use org.eclipse.jetty.security.jaas.spi.PropertyFileLoginModule (Jetty 12 package) instead of the older org.eclipse.jetty.jaas.spi.* package.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants