Fix class name for JAAS login module in Jetty 12 - #2599
Open
Francisco Robles Martín (froblesmartin) wants to merge 1 commit into
Open
Fix class name for JAAS login module in Jetty 12#2599Francisco Robles Martín (froblesmartin) wants to merge 1 commit into
Francisco Robles Martín (froblesmartin) wants to merge 1 commit into
Conversation
C3 Next Gen uses Jetty 12, and the PropertyFileLoginModule class has changed to: https://github.com/jetty/jetty.project/blob/jetty-12.1.x/jetty-core/jetty-security/src/main/java/org/eclipse/jetty/security/jaas/spi/PropertyFileLoginModule.java
Francisco Robles Martín (froblesmartin)
requested a review
from a team
as a code owner
June 24, 2026 04:46
Copilot started reviewing on behalf of
Francisco Robles Martín (froblesmartin)
June 24, 2026 04:46
View session
There was a problem hiding this comment.
Pull request overview
This PR updates the JAAS login module class reference used by Control Center Next Gen to match the package name used in Jetty 12, ensuring JAAS authentication can load the PropertyFileLoginModule correctly in Jetty 12-based deployments.
Changes:
- Update the JAAS config template to use
org.eclipse.jetty.security.jaas.spi.PropertyFileLoginModule(Jetty 12 package) instead of the olderorg.eclipse.jetty.jaas.spi.*package.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
C3 Next Gen uses Jetty 12, and the PropertyFileLoginModule class has changed to: https://github.com/jetty/jetty.project/blob/jetty-12.1.x/jetty-core/jetty-security/src/main/java/org/eclipse/jetty/security/jaas/spi/PropertyFileLoginModule.java
Before, on Jetty 11 and previous, it was located at https://github.com/jetty/jetty.project/blob/jetty-11.0.x/jetty-jaas/src/main/java/org/eclipse/jetty/jaas/spi/PropertyFileLoginModule.java
Type of change
How Has This Been Tested?
TBD
Checklist: