Skip to content

Fix for clippy and stacked borrows#23

Merged
pczarn merged 6 commits into
masterfrom
maintain
Mar 2, 2026
Merged

Fix for clippy and stacked borrows#23
pczarn merged 6 commits into
masterfrom
maintain

Conversation

@pczarn

@pczarn pczarn commented Mar 1, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@pczarn

pczarn commented Mar 1, 2026

Copy link
Copy Markdown
Contributor Author

@Jujumba r?

@Jujumba Jujumba left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this looks like running formatter on the code and fixing clippy lints, nothing too major. LGTM!

@pczarn

pczarn commented Mar 1, 2026

Copy link
Copy Markdown
Contributor Author

@Jujumba oh wow, the tool found some serious undefined behaviors here

@pczarn

pczarn commented Mar 1, 2026

Copy link
Copy Markdown
Contributor Author

in the range code

@Jujumba

Jujumba commented Mar 1, 2026

Copy link
Copy Markdown

@Jujumba oh wow, the tool found some serious undefined behaviors here

I guess it's because of a cast from &InternalNode to *mut InternalNode (in the bound! macro), but I'm not familiar with the codebase and can be wrong about it

@pczarn

pczarn commented Mar 1, 2026

Copy link
Copy Markdown
Contributor Author

@Jujumba yes, I see. I guess as the code is going down the tree it is accessing children which do not exist. I do not have the right mind space to deal with this kind of complexity today

@pczarn

pczarn commented Mar 2, 2026

Copy link
Copy Markdown
Contributor Author

@Jujumba I have some big ideas and big ambitions with this project. Will you be available to review?

It's a bunch of old, but good code, would be a shame to make it get wasted and unmaintained.

@Jujumba

Jujumba commented Mar 2, 2026

Copy link
Copy Markdown

@Jujumba I have some big ideas and big ambitions with this project. Will you be available to review?

It's a bunch of old, but good code, would be a shame to make it get wasted and unmaintained.

Certainly!

@pczarn

pczarn commented Mar 2, 2026

Copy link
Copy Markdown
Contributor Author

@Jujumba By the way, the tool was saying the code tried to access children of the trie which were already Dropped by it. Essentially accessing deallocated values.

@pczarn pczarn changed the title Fix for clippy Fix for clippy and stacked borrows Mar 2, 2026
@pczarn pczarn merged commit e29e9ea into master Mar 2, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants