Conversation
|
@Jujumba r? |
Hey, sorry for a late answer. In the nearfuture, I may only be available for code review due to time constraints (work, personal projects, yare yare) |
Besides, I'm not familiar with this repo, so I will need even more time to get myself on-boarded. We should instead focus more on bit-vec, I think. |
|
@Jujumba Alright, code review is in fact my largest concern. It will be fine if you do just that. Not sure if you want to get started with this repo. If you can, go ahead. But I realized this repo should get a pretty big rewrite in my opinion. Some of the code will be removed. |
|
Two remarks. or even more. Code review is my only concern. I cannot do it alone. Need someone like you. Please make sure to put effort into it. Am grateful for the help. Further: hopped on your website. You say you have interest in parsing (and compilers). Me too, very much. Even spent two years to make one of the most advanced, if not the most advanced parser in the world. What's more: bit-vec has 120,000 users (transitive) according to github and 223,000,000 downloads (transitive) as well as 286 crates using it (non-transitive). We made pretty popular stuff. 🎉 |
test bench_insert_large_any ... bench: 2,163,081.17 ns/iter (+/- 3,091,636.00) test bench_insert_large_low_bits ... bench: 1,058,556.80 ns/iter (+/- 206,718.37) test bench_insert_small ... bench: 636,277.47 ns/iter (+/- 373,619.40) test bench_insert_small_low_bits ... bench: 557,814.77 ns/iter (+/- 139,055.46) test find_rand_100 ... bench: 98.08 ns/iter (+/- 40.89) test find_rand_10_000 ... bench: 146.67 ns/iter (+/- 126.85) test find_seq_100 ... bench: 119.41 ns/iter (+/- 66.92) test find_seq_10_000 ... bench: 109.69 ns/iter (+/- 47.21) test insert_rand_100 ... bench: 28.29 ns/iter (+/- 13.99) test insert_rand_10_000 ... bench: 34.25 ns/iter (+/- 17.44) test insert_seq_100 ... bench: 271.00 ns/iter (+/- 45.63) test insert_seq_10_000 ... bench: 270.26 ns/iter (+/- 67.77) test iter_1000 ... bench: 26,853.57 ns/iter (+/- 2,503.34) test iter_100000 ... bench: 7,134,673.00 ns/iter (+/- 438,914.80) test iter_20 ... bench: 873.89 ns/iter (+/- 76.26)
2 participants
No description provided.