upstream: feat: Expose retention setting during proxy-cache project creation (goharbor/harbor#23863) - #937
Open
github-actions[bot] wants to merge 1 commit into
Open
upstream: feat: Expose retention setting during proxy-cache project creation (goharbor/harbor#23863)#937github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…reation (goharbor/harbor#23863) * feat: Expose retention setting during proxy-cache project creation Signed-off-by: Yannick Müller <mail@ynnk.dev> * refactor: remove unattached retention policy logic from project creation Remove unattached retention policy handling and metadata.retention_id logic from swagger.yaml and project creation handler. Signed-off-by: stonezdj <stonezdj@gmail.com> --------- Signed-off-by: Yannick Müller <mail@ynnk.dev> Signed-off-by: stonezdj <stonezdj@gmail.com> Co-authored-by: stonezdj <stonezdj@gmail.com> (cherry picked from commit de749f4e50c66fe99e254dd187b5462275a08a24) Upstream-Commit: de749f4e50c66fe99e254dd187b5462275a08a24 Upstream-PR: goharbor/harbor#23863 Upstream-Author: @Yanni8 Cherry-Pick-Status: clean Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picks upstream Harbor commit
de749f4e5from goharbor/harbor#23863.Upstream Context
Cherry-Pick Status
Upstream Description
Comprehensive Summary of your change
Issue being fixed
Fixes #23763
Please indicate you've done the following:
Review Notes
Upstream-Commit: de749f4e50c66fe99e254dd187b5462275a08a24
Upstream-PR: goharbor/harbor#23863
Cherry-Pick-Status: clean