Merged
Conversation
Contributor
Author
|
Failure is #4106 |
apostasie
force-pushed
the
tigron-2025-04-x509-helper
branch
from
1060802 to
5961a9c
Compare
AkihiroSuda
reviewed
Apr 21, 2025
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
apostasie
force-pushed
the
tigron-2025-04-x509-helper
branch
from
5961a9c to
15bb28e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On top of #4137.
Broken out of #4129.
x509 certificates manipulation is a very common test use-case, and in that context it makes sense to provide a helper for it as part of Tigron, leveraging DataTemp for automated resource cleanup, saving the need for the test author to carry over cleanup methods.
Note that the helper is focused first on generating server certificates, though it also provides an escape hatch allowing any x509 template to be signed for peeps who have custom scenarios or not happy about the defaults.
Second commit does remove the existing
nerdtest/cahelper and does clean-up code a little bit to adapt to the newutils.Cert.