Use containers.conf engine.platform as default platform#6698
Draft
TrevorBurnham wants to merge 2 commits intocontainers:mainfrom
Draft
Use containers.conf engine.platform as default platform#6698TrevorBurnham wants to merge 2 commits intocontainers:mainfrom
TrevorBurnham wants to merge 2 commits intocontainers:mainfrom
Conversation
|
Ephemeral COPR build failed. @containers/packit-build please check. |
Member
|
Try adding this to the end of the top-level go.mod: replace (
go.podman.io/storage => github.com/TrevorBurnham/container-libs/storage add-engine-platform-config
go.podman.io/image/v5 => github.com/TrevorBurnham/container-libs/image/v5 add-engine-platform-config
go.podman.io/common => github.com/TrevorBurnham/container-libs/common add-engine-platform-config
)followed by a |
TrevorBurnham
force-pushed
the
engine-default-platform
branch
3 times, most recently
from
6219a24 to
a336f70
Compare
Member
|
@TrevorBurnham looks like this needs a rebase now. |
nalind
reviewed
Mar 19, 2026
tests/containers_conf.bats
Outdated
| assert $status -eq 0 | ||
| alg="${output%%:*}" | ||
| hex="${output##*:}" | ||
| run jq -r '.os' "$TEST_SCRATCH_DIR"/output/blobs/"$alg"/"$hex" |
Member
There was a problem hiding this comment.
This section can probably set local config="$TEST_SCRATCH_DIR"/output/$(oci_image_config "$TEST_SCRATCH_DIR"/output), and then point jq at "$config".
nalind
reviewed
Mar 19, 2026
| cat >${TEST_SCRATCH_DIR}/containers.conf << EOF | ||
| [engine] | ||
| platform = "linux/amd64" | ||
| EOF |
Member
There was a problem hiding this comment.
Most of our tests run on amd64, so I'm not sure that this ensures that we're using the value from the configuration file.
Author
There was a problem hiding this comment.
Good call. I've switched to linux/arm64 so the test actually verifies that the config is being used.
TrevorBurnham
force-pushed
the
engine-default-platform
branch
from
a336f70 to
8afa014
Compare
When no --platform, --os, --arch, or --variant flags are specified, fall back to the platform value from containers.conf [engine] section. This allows users to set a default platform for all image operations (pull, build, from) without passing flags each time. Depends on: containers/container-libs#669 Signed-off-by: Trevor Burnham <trevorburnham@gmail.com>
Replace go.podman.io/common, go.podman.io/image/v5, and go.podman.io/storage with TrevorBurnham/container-libs@add-engine-platform-config to test the new engine platform config field in buildah CI. Depends on: containers/container-libs#669 Signed-off-by: Trevor Burnham <trevorburnham@gmail.com>
TrevorBurnham
force-pushed
the
engine-default-platform
branch
from
8afa014 to
5a58086
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: containers/container-libs#669
What type of PR is this?
/kind feature
What this PR does / why we need it:
When no --platform, --os, --arch, or --variant flags are specified, fall back to the platform value from containers.conf [engine] section.
How to verify it
containers.conf--platformflagFor example:
buildah pull alpine buildah inspect --format '{{.OCIv1.Architecture}}' alpineExpect: s390x
Which issue(s) this PR fixes:
Related to containers/podman#25641
Does this PR introduce a user-facing change?
Yes: