remove two deprecated unused functions

[Luap99]

pkg/util: remove StringInSlice()

It is not used by other tools anymore and callers should just use
slices.Contains() now.

---

pkg/config: remove ValidatePullPolicy()

It was deprecated and beside on caller here it doesn't seem to be used
by podman/buildah so just drop it.

Also ParsePullPolicy() already does strings.ToLower() on the input so
there is no need for the caller to do that again.

Summary by Sourcery

Remove two deprecated and unused functions and update callers to use the recommended alternatives

Enhancements:

• Remove deprecated util.StringInSlice and drop its slices import
• Remove deprecated config.ValidatePullPolicy and simplify pull policy validation to call ParsePullPolicy directly

[sourcery-ai]

Reviewer's Guide

This PR removes two deprecated utility functions (StringInSlice and ValidatePullPolicy), cleans up related imports, and updates remaining callers to use slices.Contains and ParsePullPolicy directly.

Class diagram for removal of StringInSlice and ValidatePullPolicy functions

classDiagram
    class util {
        %% StringInSlice function removed
        %% StringMatchRegexSlice(s string, re []string) bool
    }
    class config {
        %% ValidatePullPolicy function removed
        ParsePullPolicy(s string) (PullPolicy, error)
    }
    class EngineConfig {
        +Validate() error
        PullPolicy : string
    }
    EngineConfig --> config : uses ParsePullPolicy

Loading

File-Level Changes

Change	Details	Files
Removed deprecated StringInSlice function and its import.	Deleted the slices import Removed the StringInSlice function and its deprecation comment	pkg/util/util.go
Dropped the ValidatePullPolicy wrapper in favor of ParsePullPolicy.	Removed the ValidatePullPolicy function and its deprecation notice	pkg/config/pull_policy.go
Refactored config validation to call ParsePullPolicy directly.	Eliminated strings.ToLower on PullPolicy Replaced ValidatePullPolicy with ParsePullPolicy in validation logic	pkg/config/config.go

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @Luap99 - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, sourcery-ai[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [Luap99]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[baude]

LGTM

[mheon]

/lgtm