Conversation
… grid field only on old start / stop elements, change original nested element to get working with separator elements # Conflicts: # .phpcq.lock
# Conflicts: # .phpcq.lock # .phpcq.yaml.dist # composer.json
- Fix iterator for each column - Add clearfix divs to reset grid rows in bs_grid_wrapper template
|
@cboelter Thanks for your contribution. I had a look at this again and I realized that the origin twig template was incomplete. It did not iterate over the grid. I intended to remove all grid separator elements. So the grid wrapper assumes that each child is a new column. As a result of this, each column containing more than one element has to be wrapped by the contao group content element. This is currently missing in the migration script, probably because of a misunderstanding of the goal that i had in mind. |
|
I also changed the configuration which enabled the migration. Following the symfony bundle guidlines I added a bundle configuraiton for it. |
|
@dmolineus thanks for your Feedback und code fixes :-) should I add it to the migration or will you do? |
|
Would be great if you can provide the migration. Not sure how to detect/handle nested grids. |
|
I will try to provide a changed migration in the next week :-) I'm not really sure that we have to detect nested grids. The Migration currently detects all start / stop groups and changes them, so also nested groups should be migrated correctly?!?! |
You're probably right. Every content between a start/separator/stop element belongs to a group element (if multiple elements exist) or can exist as single element. This way it doesn't matter if an element is a nested grid or not. |
|
Perfect 😊 I was not able to change migration, I will do in the first week of may. Have to recover from my small accident first 🙄 |
|
Fine, gonna have to take a look at the accordion bundle. Get well soon |
2 participants
No description provided.