fix(slack): delete correct notification row instead of the last one [] - #11264
Merged
Lisa White (whitelisab) merged 1 commit intoAug 10, 2026
Merged
Conversation
Notification rows were keyed by array index in NotificationsPanel, so deleting a middle row caused React to reconcile the wrong DOM node (always the last row) instead of the one that was clicked, even though the underlying store removed the correct item. Give each notification a stable id and key on that instead.
zacharyyankiver
changed the title
Lisa White (whitelisab)
approved these changes
Aug 10, 2026
Lisa White (whitelisab)
deleted the
fix/slack-notification-delete-wrong-item
branch
August 10, 2026 16:37
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
key={index}), so deleting a row in the middle of the list caused React to reconcile the last DOM row rather than the one the user clicked delete on. The store logic (removeNotificationAtIndex) already removed the correct item — this was purely a rendering/reconciliation bug.idtoSlackNotification(generated withuuid), assigned on creation and backfilled on load for notifications persisted before this change, and keyed the list bynotification.idinstead of index.Test plan
npx tsc --noEmitpassesnpx eslintpasses on changed filesnpx vitest run— all existing tests pass (8/8)🤖 Generated with Claude Code