Skip to content

fix: add 'access' to Roles ActionType type#2170

Open
Sune Hinz (sunehinz) wants to merge 1 commit intocontentful:masterfrom
sunehinz:master
Open

fix: add 'access' to Roles ActionType type#2170
Sune Hinz (sunehinz) wants to merge 1 commit intocontentful:masterfrom
sunehinz:master

Conversation

@sunehinz
Copy link
Copy Markdown

@sunehinz Sune Hinz (sunehinz) commented Feb 10, 2024

Summary

Add missing access attribute to Roles ActionType type.

Description

The access attribute on Roles ActionType type is missing. The API support this, and returns policies with this value. The issue is solely a Typescript type issue.

Motivation and Context

Removes Typescript errors and adds access to intellisense.

Checklist (check all before merging)

  • Both unit and integration tests are passing
  • There are no breaking changes
  • Changes are reflected in the documentation

@sunehinz Sune Hinz (sunehinz) requested a review from a team as a code owner February 10, 2024 11:20
@sunehinz Sune Hinz (sunehinz) changed the title chore: add 'access' to Roles ActionType type fix: add 'access' to Roles ActionType type Feb 10, 2024
Copy link
Copy Markdown
Contributor

@mgoudy91 Mitch Goudy (mgoudy91) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks for the PR!

@mgoudy91 Mitch Goudy (mgoudy91) enabled auto-merge (squash) February 13, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants