Improve find_inline_quantity function - #99
Merged
Conversation
commit: |
Zheoni
changed the title
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function tries to find quantities in a string during analysis. It's used by the INLINE_QUANTITIES extension.
The problem I faced is that it failed a somewhat common case like "Then add 10 ml." because the ending "." was in the unit, and the unit was not recognised. This small fix should help detect more cases supossing unit names are alphabetic.
I have not been maintaining this repo in more than a year, so I don't want to be the one merging changes. 😅