Remove remote mktemp dependency from report#8
Merged
Conversation
Build the remote include list with POSIX shell positional parameters so report stays within its declared portable command profile. Cover the generated script and run the SSH report E2E with mktemp removed from the managed host.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The read-only report used
mktempon the remote host even though the portable capability contract requires onlysh,tar,cp,mkdir, andrm. A host accepted bydoctorcould therefore fail at report time.What changed
/dev/nullmktempunavailableValidation
mise run fix: 138 tests plus all static checksmise run test:e2e: 16/16 on GNU tar 1.34 and 16/16 on GNU tar 1.35mise run test:e2e:pex: 16/16 on the packaged PEX with GNU tar 1.35