hopefully fix netlify docs deploy#4871
Merged
Merged
Conversation
tessalt
commented
May 6, 2026
tessalt
commented
Contributor
- netlify was using npm, not pnpm, so was not getting a lockfile, and ended up with bad webpack versions. this will hopefully fix it
✅ Deploy Preview for gallant-galileo-14878c ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kabeaty
approved these changes
May 6, 2026
helderdb
reviewed
May 7, 2026
| "engines": { | ||
| "node": ">=18.0" | ||
| }, | ||
| "pnpm": { |
There was a problem hiding this comment.
This feels hacky.
I've taken a quick look at fully upgrading pnpm & node to a more recent version. Wouldn't it be better to align this better as a general update and make sure all versions are more up to date?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.