Rework RideType for new standardized schema#598
Conversation
|
[diff-counting] Significant lines: 22. |
mjaydenkim
left a comment
There was a problem hiding this comment.
I know this isn't done yet but my notes so far - this overall list of TODOs makes sense and I don't see any problems with it (except for what I noted about the name LOL)!
There was a problem hiding this comment.
Very small note b/c this schema looks great to me, but I feel like creating a RideType2 on top of the existing RideType will be confusing -- maybe we should name it RideTypeWithRecurrence or something b/c it might be poor documentation-wise to just name it RideType2
There was a problem hiding this comment.
Yeah, it's definitely only meant to be a temporary switch from RideType. I thought it might make sense to have a separate type that avoids deleting/modifying the original, so we don't break the entire codebase at once, and then at the end we can delete the original RideType and rename RideType2. But this might be difficult for the external dynamoDB, so I'm not sure.
anika-4444
left a comment
There was a problem hiding this comment.
Some notes on ride design doc:
- The requested vs final fields is a good idea!
- For bounds on how far into the future a ride can be requested, a per-semester basis might also be a good idea. Because students use CULift to get to their classes/on campus activities (which change between fall and spring), I think it makes sense to limit recurrences there. That way someone can't create a recurring ride in May that CULift will have to manually delete as it runs into June.
- Will operational status be updated by the driver (after a ride has been completed) or using time? If a driver forgets to update status, what will happen?
| - driver? | ||
| - requestedPickupTime | ||
| - finalPickupTime? | ||
| - requestedDropoffTime |
There was a problem hiding this comment.
Because the user does not know exactly how long their ride will take, I'm not sure requested drop off time is a necessary field. Currently, the modal for student and admin ride creation should not allow for the user to pick their drop off time according to the bug bash notes. However, I still think storing a general end time is a good idea, especially for the day calendar that displays rides. I'm currently working on using Google Maps data to add a ride duration estimate (with added buffer minutes) for the student and admin ride view. That data might be better here than requested drop off time.
Summary
This PR is meant to mark progress on a reworked schema for rides across the codebase. Right now, it only contains a few TODO comments outlining a basic plan for implementation, and should not be merged. It mostly serves to easily link to this design document and serve as an indicator for future progress. This PR will be updated as that progress materializes.
This pull request is the first step towards implementing the new
RideType:Test Plan
We will need rigorous testing to ensure that rides function correctly under this new schema.
Breaking Changes