Remove End Time#599
Open
anika-4444 wants to merge 2 commits into
Open
Conversation
Member
|
[diff-counting] Significant lines: 94. |
anika-4444
changed the title
mjaydenkim
approved these changes
Oct 24, 2025
mjaydenkim
left a comment
mjaydenkim
left a comment
Contributor
There was a problem hiding this comment.
Nice -- code looks good and everything works as expected on my end! My only question -- is there a reason why the buffer is 15 minutes specifically, or is that just a placeholder?
Contributor
|
don't merge, pending confirmation from CULift that we can get rid of end time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request is the first step towards implementing feature Foo
Test Plan
Ensure
Notes
This PR is merged into changes (not master) because this is the branch Carriage is currently working in for our bug bash of Desmond's changes.