Create shared pnpm package#634
Merged
Merged
Conversation
Member
|
[diff-counting] Significant lines: 8096. This diff might be too big! Developer leads are invited to review the code. |
Continue using REACT_APP prefix for saved github actions secrets
dti-github-bot
requested review from
Destaq,
burninglilies and
oscarwang20
and removed request for
oscarwang20
Base automatically changed from
bek76/fix-mobile-login
to
bek76/pnpm-docker-deploy
January 14, 2026 18:23
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for carriage-web ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mjaydenkim
approved these changes
Mar 5, 2026
`pnpm` branch: Replace Create React App with Vite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some types are improperly shared between the frontend and backend, causing the frontend to have a hard dependency on the backend during the build step. This PR properly structures the repo with a new
sharedpackage, and moves all shared types there.Note that this shared package cannot currently contain code that runs on the frontend, like functions (I havent' tested the backend). This is because there is no build step where it is turned into javascript, and Create React App isn't great at this. This problem should be fixed in the near future with Vite, so this PR also opens the doors to this as an easy next step.
@carriage-web/shared