Skip to content

Fully Custom Location#650

Merged
mjaydenkim merged 5 commits into
masterfrom
fully-custom-loc
Jan 7, 2026
Merged

Fully Custom Location#650
mjaydenkim merged 5 commits into
masterfrom
fully-custom-loc

Conversation

@anika-4444

Copy link
Copy Markdown
Contributor

Summary

This pull request is the first step towards implementing feature Foo

  • implemented ability to enter any custom location (does not have to be a real address)
  • added custom location placeholder map
image image image

Notes

Because custom locations no longer require an address, the Google Maps got kind of wonky. To work around this problem, I added a placeholder for the map that appears when a custom location is used.

Overall, this method could cause more repeat locations than what was there before (which only created new locations based on if the latitude/longitude could not be found in the db), but because we cannot require a real address, I think we will have to just deal with this. One way to mitigate this could be to search the db for locations that have the same name. Will add this asap

@anika-4444 anika-4444 requested a review from a team as a code owner January 5, 2026 00:30
@dti-github-bot

dti-github-bot commented Jan 5, 2026

Copy link
Copy Markdown
Member

[diff-counting] Significant lines: 535.

@mjaydenkim mjaydenkim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small note: I did notice that there are some overlaps here and #647; I'll sort those out when I have time.

Everything works cleanly and the map enabling/disabling based on custom locations is quite nice, better than I had. I think worrying about duplicate locations is a next semester issue imo, probably shouldn't raise major issues during winter testing. Didn't do a super robust review so another one would be great but I didn't notice any problems, this looks pretty seamless to me!! Great work!

Comment thread frontend/src/pages/Rider/Schedule.tsx Outdated

@YottaYocta YottaYocta left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I second @mjaydenkim; these changes look good! @anika-4444 wanted your opinion but should we add a way for the admins to request a custom ride in this PR, or do so in a future one? I noticed that admins could only add rides based on existing locations.

Image

@mjaydenkim

Copy link
Copy Markdown
Contributor

@YottaYocta i believe that’s in my pr #647 which is kinda outdated after this one but i can merge that element in!

@YottaYocta

Copy link
Copy Markdown
Collaborator

That would be very cool

@mjaydenkim mjaydenkim merged commit 7b1d92e into master Jan 7, 2026
4 of 5 checks passed
@mjaydenkim mjaydenkim deleted the fully-custom-loc branch January 7, 2026 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants