fix: introduce gRPC input validation - #677
Merged
Merged
Conversation
Validate that both label & ID queries have sane limits on inputs. For label query - ensure that values are populated, for the ID query ensure a maximum budget for the regexp to be compiled. In real life ID queries should be simple (and probably regexp is an overkill here), so limit the regexp maximum complexity. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
frezbo
approved these changes
Aug 31, 2026
Update Go dependencies and rekres. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
force-pushed
the
fix/grpc-input-validation
branch
from
August 31, 2026 12:10
4690905 to
8eab351
Compare
Member
Author
|
/m |
Collaborator
|
@smira merge was not performed: push: To https://github.com/cosi-project/runtime.git |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate that both label & ID queries have sane limits on inputs.
For label query - ensure that values are populated, for the ID query
ensure a maximum budget for the regexp to be compiled. In real life ID
queries should be simple (and probably regexp is an overkill here), so
limit the regexp maximum complexity.