Skip to content

fix: a Rust linter warning#359

Open
larry0x wants to merge 1 commit into
cosmos:masterfrom
left-curve:rust/clippy-fix
Open

fix: a Rust linter warning#359
larry0x wants to merge 1 commit into
cosmos:masterfrom
left-curve:rust/clippy-fix

Conversation

@larry0x

@larry0x larry0x commented Aug 29, 2024

Copy link
Copy Markdown
Contributor

The use ics23; statement in the no-std check crate triggers the following linter warning:

warning: this import is redundant
 --> no-std-check/src/lib.rs:9:1
  |
9 | use ics23;
  | ^^^^^^^^^^ help: remove it entirely
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
  = note: `#[warn(clippy::single_component_path_imports)]` on by default

This can be fixed by changing it to use ics23::*;.

@codecov

codecov Bot commented Aug 29, 2024

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.55%. Comparing base (1363533) to head (ca29ba9).
⚠️ Report is 39 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #359   +/-   ##
=======================================
  Coverage   65.55%   65.55%           
=======================================
  Files           7        7           
  Lines        3609     3609           
=======================================
  Hits         2366     2366           
  Misses       1243     1243           
Flag Coverage Δ
rust 65.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@colin-axner
colin-axner requested a review from romac October 8, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant