Merged
Conversation
cotes2020
requested changes
Mar 30, 2026
Owner
cotes2020
left a comment
cotes2020
left a comment
There was a problem hiding this comment.
Firefox handles javascript: URLs such that if the expression does not return undefined, it treats the return value as page content and displays it, which causes navigation to a blank page showing the mailto address. Chrome and Safari do not handle it this way, so they are not affected.
The fix is to wrap the expression in void(), ensuring it returns undefined:
javascript:void(location.href = 'mailto:' + ['{{ email[0] }}','{{ email[1] }}'].join('@'))
cotes2020
requested changes
Apr 3, 2026
Add @cotes2020's requested change Co-authored-by: Cotes Chung <11371340+cotes2020@users.noreply.github.com> Signed-off-by: lynkos <kiwi2mii@gmail.com>
cotes2020
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Clicking the Mail icon in Firefox redirects the user to a new blank page that displays the
mailtoaddress. See the Additional context section for screenshots. Note: This bug doesn't appear in Chrome or Safari.This change doesn't require any additional dependencies since it's a one-line change in
_includes/sidebar.html.It also doesn't break the behavior in Chrome or Safari (i.e. no new bug(s) introduced) since this bug only affects Firefox, to my knowledge.
Please refer to my fork and click the Mail icon for a working example of my fix (i.e. prevent site from redirecting to a blank page after clicking the Mail icon).
Additional context
Clicking the Mail icon in Firefox
Firefox user is redirected to this page after clicking the icon
