Implement a fallback IP mechanism in topology JSON#196
Merged
Conversation
vipbhardwaj
reviewed
Jun 7, 2025
vipbhardwaj
left a comment
vipbhardwaj
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but there is a merge conflict as well there.
vipbhardwaj
approved these changes
Jun 7, 2025
This way if for some reason the IP auto detection doesn't work locally a quick way to resolve it is present. This should NOT be used for a permanent solution on Jenkins infrastructure, though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way if for some reason the IP auto detection doesn't work locally a quick way to resolve it is present. This should NOT be used for a permanent solution on Jenkins infrastructure, though.