Remove the dataset parameter from the prebuild logic#199
Merged
Conversation
This means taking the dataset version out of the filename and not having a Jenkins prebuild option to specify it anymore. Prebuilt test servers will hard code 3.2 for now until the copy dataset logic can be fully removed.
borrrden
force-pushed
the
remove_dataset_build
branch
from
36a34fc to
5905689
Compare
Member
Author
|
This looks bigger than it actually is because a lot of stuff needs to be repeated across the different test server platforms. Basically, removing an argument from the abstract base constructor which is then echoed into the subclasses. Also removing the dataset version from copy_datasets. copy_datasets is now deprecated and will be removed once all platforms have asset downloading in place. |
pasin
approved these changes
Jun 7, 2025
bmeike
approved these changes
Jun 9, 2025
bmeike
left a comment
bmeike
left a comment
Contributor
There was a problem hiding this comment.
This is because the dataset is now chosen at runtime?
Member
Author
Precisely. The current prebuild system is designed to make two builds (one for 3.2 and one for 4.0), and I simplified it to make only one (dataset chosen at runtime). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This means taking the dataset version out of the filename and not having a Jenkins prebuild option to specify it anymore. Prebuilt test servers will hard code 3.2 for now until the copy dataset logic can be fully removed.