-
Notifications
You must be signed in to change notification settings - Fork 1
Parametrize Multipeer QE tests to run mixed-mode testing #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
barkha06
wants to merge
58
commits into
main
Choose a base branch
from
bluetooth-multipeer-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 55 commits
Commits
Show all changes
58 commits
Select commit
Hold shift + click to select a range
83cda24
added export UV_VENV_CLEAR=1 flag to shell scripts
barkha06 0316d30
removed disconnected android devices
barkha06 b6db4bd
modified label since mob-e2e-mac is down
barkha06 7693175
latestbuilds uploaded IOS testserver is broken, modifying code to upl…
barkha06 c3c3b96
latestbuilds uploaded IOS testserver is broken, modifying code to upl…
barkha06 b2ba414
comment transports since it's not present in 4.0.3
barkha06 eee6cb4
removed 45291VDJH01660 from topology
barkha06 32e127b
removed 51131XEKB7DBF1 from topology
barkha06 0da2aeb
fix merge-dict error
barkha06 cf8f39d
removed 172.16.150.165 since it's unreachable
barkha06 523a9d7
rebuilding android testserver
barkha06 d8753ed
change prebuild job host mac-mini-new
barkha06 7b7f28a
changed ios jenkins setup
barkha06 07138ef
Modified ReplicatorManager.java to add additional logging
barkha06 8d75dc2
Modified ReplicatorManager.java to add additional logging
barkha06 88248df
Modified ReplicatorManager.java to add additional logging
barkha06 f139a69
undoing changes
barkha06 f616c08
Modifying MultipeerReplicatorManager.java and test_multipeer.py
barkha06 f2b8650
Modifying MultipeerReplicatorManager.java and test_multipeer.py
barkha06 ce2d261
Modifying MultipeerReplicatorManager.java
barkha06 937f583
Modifying test_multipeer.py
barkha06 f8560a4
Modifying default dataset version for test
barkha06 dcc9a6a
Modifying zip source to testserver's parent directory
barkha06 93fbcf5
setting download as true for multipeer devices
barkha06 86203e4
setting retry for each device
barkha06 06e3ad4
rebased from main
barkha06 3020ea5
added export UV_VENV_CLEAR=1 flag to shell scripts
barkha06 29f8cf5
removed disconnected android devices
barkha06 97d8f94
modified label since mob-e2e-mac is down
barkha06 5babf74
latestbuilds uploaded IOS testserver is broken, modifying code to upl…
barkha06 a4a9cb8
latestbuilds uploaded IOS testserver is broken, modifying code to upl…
barkha06 ed8a6e2
comment transports since it's not present in 4.0.3
barkha06 b37cc08
removed 45291VDJH01660 from topology
barkha06 cff129f
removed 51131XEKB7DBF1 from topology
barkha06 d263379
removed 172.16.150.165 since it's unreachable
barkha06 48788fd
rebuilding android testserver
barkha06 bdc6d2c
change prebuild job host mac-mini-new
barkha06 073e270
changed ios jenkins setup
barkha06 6a529d8
Modified ReplicatorManager.java to add additional logging
barkha06 2ddd3e0
undoing changes
barkha06 89bdc09
Modifying MultipeerReplicatorManager.java and test_multipeer.py
barkha06 ec6d0dd
Modifying MultipeerReplicatorManager.java and test_multipeer.py
barkha06 4c41c8e
Modifying MultipeerReplicatorManager.java
barkha06 7052ac5
Modifying default dataset version for test
barkha06 c2e6d4a
Modifying zip source to testserver's parent directory
barkha06 30fc2f3
setting download as true for multipeer devices
barkha06 e17545c
removing unnecessary changes
barkha06 969075d
multipeer changes for BT
barkha06 931608f
temporary fix for android
barkha06 47d9b96
remove temporary fix
barkha06 928ac6e
remove temporary fix
barkha06 afa4e10
remove temporary fix
barkha06 a3b6698
remove temporary fix
barkha06 c23e0f6
Modified large_doc test
barkha06 722824f
Modified large_doc test
barkha06 6fdea36
fix parametrize
barkha06 05fa80d
fix parametrize
barkha06 f29b5c8
Modified test retry logic
barkha06 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This creates a makeshift enum out of a magic string for no reason. MultipeerTransportType is already a flag enum, which means it can be bitwise or together (MultipeerTransportType.BLUETOOTH | MultipeerTransportType.WIFI).
Also this seems like a helper method specific to a test suite and not an API method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a test helper to help generate a mixed mode set with even distribution of wifi only, BT only and wifi+bluetooth devices. I need it for both test_multipeer.py and test_system_multipeer.py so I assumed it could go in the API to make it easy to import.
I've used strings for ease-of-use since the test parameter could of of type MultipeerTransportType or string to represent mixed-mode making it two different types of parameters.
Do you think there's a better way to do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are flag style enums though so they can represent both anyway like I mentioned above. It doesn't seem like it is the class's job to create collections of itself though, that seems like a higher level thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where do you recommend I place this function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it were me, I'd start a collection of test helper functions inside of the tests/QE folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an update, Vipul has now started a shared logic section that you can add this to.