feat: Updated schema for SGW upgrade jobs' better visualization overall#409
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors how Sync Gateway (SGW) upgrade job results are emitted to Greenboard to support a new visualization model: each pytest iteration records structured upgrade-step data, and a single aggregated “batch” document is intended to be uploaded once per upgrade run.
Changes:
- Switched upgrade-mode Greenboard reporting from “upload each step” to “record each step to a shared JSON state file”.
- Added
GreenboardUploader.record_upgrade_step(...)andGreenboardUploader.upload_upgrade_batch(...)to support the new aggregated schema (iterations,failedAt, etc.). - Updated the rolling upgrade Jenkins script to set up an aggregated results file and attempt a batch upload on exit.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
jenkins/pipelines/QE/upg-sgw/test_rolling.sh |
Initializes an upgrade-results state file and installs an EXIT trap intended to upload a single aggregated batch result. |
client/src/cbltest/plugins/greenboard_fixture.py |
For upgrade runs, records iteration results to a JSON state file instead of uploading per-iteration docs. |
client/src/cbltest/greenboarduploader.py |
Implements JSON state append (record_upgrade_step) and a single aggregated Greenboard upload (upload_upgrade_batch). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
borrrden
requested changes
May 11, 2026
borrrden
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CBG-5369
There is a need to change the visualization for SGW Upgrade test runs shown up on greenboard because the upgrade path and the source and target versions make it very much different from the traditional bar-graph way of viewing the passed and failed tests. I am still working on the POC and finalizing something similar to Ben's idea.
This PR involves the schema changes for the same, it will have a bit more commits before I assign an human reviewer to it.