Enforce minimum Perl 5.010 at runtime#44
Closed
toddr-bot wants to merge 1 commit into
Closed
Conversation
MIN_PERL_VERSION was already set in Makefile.PL but no module declared 'use 5.010;', so the version requirement was only enforced at install time by CPAN clients. Adding the declaration to all 20 .pm files and 4 bin/ scripts ensures Perl itself rejects loading on versions < 5.10. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
use 5.010;to all 20 modules and 4 bin/ scripts to enforce the minimum Perl version at runtime.Why
MIN_PERL_VERSION => '5.010'in Makefile.PL only guards install time (CPAN clients check it). Withoutuse 5.010;in the source, Perl itself won't reject loading on older versions — a user who installs manually or from a tarball gets no protection.How
Added
use 5.010;beforeuse strict;in every.pmfile and the 4 active bin/ scripts. The CI testing matrix (since-perl: 5.10) was already correct and needed no changes.Testing
Full test suite passes: 174 tests across 7 test files, all successful.
🤖 Generated with Claude Code
Quality Report
Changes: 24 files changed, 24 insertions(+)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline